Default to the ramcontroller that matches the current ROM #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each ramcontroller may provide a Lua pattern to match against the ROMs name (as provided by gameinfo.getromname()); the ramcontroller with the first matching pattern is used as the default. The pattern is specified by a comment rather than a function or global variable since (a) it's slow to run all of the ramcontrollers on startup, and (b) the ramcontrollers may modify global state. A comment is also trivially backwards-compatible with any existing third-party ramcontrollers.
|
I opted not to hide non-matching ramcontrollers in case the matching fails for some reason (e.g., the 'OoTR' game name changes) or a different ROM is loaded after the lua script has been started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each ramcontroller may provide a Lua pattern to match against the ROMs name (as provided by gameinfo.getromname()); the ramcontroller with the first matching pattern is used as the default.
The pattern is specified by a comment rather than a function or global variable since (a) it's slow to run all of the ramcontrollers on startup, and (b) the ramcontrollers may modify global state. A comment is also trivially backwards-compatible with any existing third-party ramcontrollers.