Skip to content

Commit

Permalink
Disable state locking if inc'ing state w/ ACTION
Browse files Browse the repository at this point in the history
This fixes a bug report from Elomavi that you could still softlock from
warping to ship and incrementing the gamestate by pressing ACTION, which
is diverging behavior from how it was in 2.3. Warping to ship and
incrementing by pressing ACTION is useful behavior for a couple niche
speedrun categories.

I had already fixed this earlier by ignoring state locking if
glitchrunner 2.2 or 2.0 was enabled, but softlocks could still happen
because having glitchrunner mode off still enabled you to increment the
gamestate when otherwise unintended. Softlocks shouldn't happen.

But without removing state locking entirely, I've chosen a middle ground
where it will only be disabled if you press ACTION. That signifies
intent that you still want to perform state incrementing glitches even
with glitchrunner mode off (but in the future it could be considered a
2.3/2.4 glitch that could be patched and made re-enable-able). That way,
casual players can't interrupt the warp to ship by accident (unless they
accidentally press ACTION) while softlocks will be removed.
  • Loading branch information
InfoTeddy committed May 26, 2024
1 parent ff6bb68 commit 16d75d2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions desktop_version/src/Input.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2617,6 +2617,7 @@ void gameinput(void)
|| !game.glitchrunkludge)
{
game.state++;
game.unlockstate();
}
game.jumpheld = true;
game.glitchrunkludge=true;
Expand Down

0 comments on commit 16d75d2

Please sign in to comment.