feat(mysql): tendbcluster、mysql支持记录级闪回 #8225 #8351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterxucai
force-pushed
the
feat/mysql_flashback/#8225
branch
2 times, most recently
from
9470336 to
fbb2c57
Compare
peterxucai
force-pushed
the
feat/mysql_flashback/#8225
branch
from
fbb2c57 to
ee5428d
Compare
iSecloud
reviewed
Jan 13, 2025
| except csv.Error: | ||
| raise serializers.ValidationError(_("输入内容不符合csv格式")) | ||
|
|
||
| def validate_table_fields(self, info, input_fild_names): |
There was a problem hiding this comment.
可以考虑把这个方法放到RemoteServiceHandler中，作为校验库表字段是否存在的通用方法
| @@ -31,6 +31,10 @@ def validate(self, attrs): | |||
| super(TendbBaseOperateDetailSerializer, self).validate_cluster_can_access(attrs) | |||
| # 校验flash的库表选择器 | |||
| RemoteServiceHandler(bk_biz_id=self.context["bk_biz_id"]).check_flashback_database(attrs["infos"]) | |||
| # 库表校验结果判断 | |||
| self.check_flashback_database_result(attrs) | |||
There was a problem hiding this comment.
把前面的
RemoteServiceHandler(bk_biz_id=self.context["bk_biz_id"]).check_flashback_database(attrs["infos"])放到check_flashback_database_result这个方法里面吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.