Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] Reactphp update to PHP/8.4 #9529

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Jan 14, 2025

Disabled db tests till fixed, or fail all the tests. So it's ready for Round 23.
In the last runs was broken.

#9408

#8550

Comment on lines +13 to +21
# libuv
# RUN apt-get install -yqq libuv1-dev > /dev/null \
# && pecl install uv-beta > /dev/null \
# && echo "extension=uv.so" > /etc/php/8.4/cli/conf.d/uv.ini

# libevent
RUN apt-get install -y libevent-dev > /dev/null \
&& pecl install event-3.1.4 > /dev/null \
&& echo "extension=event.so" > /etc/php/8.4/cli/conf.d/event.ini
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely out of interest, why the switch to event from uv?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry !

I test it locally also with libevent, to compare with other frameworks that use it too.
Libuv is only used for Reactphp, not other php frameworks, so we can compare with others.

Also it's good to compare with both event systems and check the faster one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With libevent other PHP frameworks have up to 3,854,134 req/s with the plaintext test.
And Reactphp with libuv have a max of ~70,000 req/s.

So we can check if it's a problem with the event system.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry !

Please, no need to be sorry!

With libevent other PHP frameworks have up to 3,854,134 req/s with the plaintext test. And Reactphp with libuv have a max of ~70,000 req/s.

So we can check if it's a problem with the event system.

That be pretty neat! Also, the current set up is fully single process, will have a look at some point at how easy it is to rework it into multi core support.

@msmith-techempower msmith-techempower merged commit f56b5fa into TechEmpower:master Jan 16, 2025
4 checks passed
@joanhey joanhey deleted the react-php8.4 branch January 16, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants