refactor(file): 파일 도메인 리팩토링 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hw9402
requested changes
Apr 29, 2024
| import com.project.bumawiki.global.s3.controller.dto.ImageResponse; | ||
| import com.project.bumawiki.global.s3.service.CommandImageService; | ||
| import com.project.bumawiki.domain.file.presentation.dto.R2FileResponseDto; | ||
| import com.project.bumawiki.domain.file.service.CommandFileService; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/api/s3") |
Comment on lines
38
to
44
| auth: | ||
| jwt: | ||
| header: ${HEADER} | ||
| secret: ${SECRET} | ||
| accessExp: ${ACCESS_EXP} | ||
| refreshExp: ${REFRESH_EXP} | ||
| prefix: ${PREFIXES} |
There was a problem hiding this comment.
prefix가 변경되면서 자동으로 안쓰는 부분이 지워지고 올라간거같네요.
롤백처리하겠습니당
qlido
previously approved these changes
Apr 30, 2024
Comment on lines
33
to
35
| return R2FileResponseDto.from( | ||
| commandFileService.uploadFile(file) | ||
| ); |
There was a problem hiding this comment.
new를 바로 사용하는게 더 좋을 것 같아 수정하겠습니다
|
좋은 코멘트 감사합니다. |
jacobhboy
approved these changes
Apr 30, 2024
qlido
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image 도메인과 S3 도메인을 file 도메인으로 변경 / 병합 하였습니다.
고민한 부분
R2에서 파일을 가져오는 것과 로컬에서 가져오는 것을 R2로 묶지 않았습니다.
commandFileService에 대한 테스트코드를 작성하지 않았습니다.
위와 같은 문제로 fixtureMonkey를 통한 다양한 경우의 테스트 데이터 생성과 데이터 롤백에 대한 어려움이 있는 도메인이라 판단되었습니다