Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simplify docs logic, fix loading framework from localStorage #157

Merged
merged 9 commits into from
Jan 26, 2024
Merged

refactor: Simplify docs logic, fix loading framework from localStorage #157

merged 9 commits into from
Jan 26, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jan 26, 2024 •
edited
Loading

  • Removed v2, frameworkConfig and versionConfig options on <DocsLayout />
  • Moved createLogo logic into <DocsLogo /> component
  • Replaced gradientText with colorFrom and colorTo, which are now also applied to <DocsLayout />
  • Marked frameworkMenus as required field in config.json
  • Fixed missing docs when the framework saved in localStorage isn't available for that project

@vercel Vercel
Copy link

vercel bot commented Jan 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tanstack-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 2:43am

@lachlancollins lachlancollins changed the title refactor: Simplify docs logic refactor: Simplify docs logic, fix loading framework from loading storage Jan 26, 2024
@lachlancollins lachlancollins changed the title refactor: Simplify docs logic, fix loading framework from loading storage refactor: Simplify docs logic, fix loading framework from localStorage Jan 26, 2024
@lachlancollins lachlancollins marked this pull request as ready for review January 26, 2024 02:58
@lachlancollins lachlancollins merged commit a09dbd3 into main Jan 26, 2024
4 checks passed
@lachlancollins lachlancollins deleted the cleanup branch January 26, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannerlinsley tannerlinsley tannerlinsley approved these changes

@fulopkovacs fulopkovacs Awaiting requested review from fulopkovacs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlancollins @tannerlinsley