Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add copy to clipboard button to code blocks #104

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

beerose
Copy link
Contributor

@beerose beerose commented Oct 25, 2023

Hey!

I was missing a copy to clipboard button in the docs, so here it goes. I could also move it somewhere else (next to the lang badge?). What do you think?

CleanShot.2023-10-25.at.21.22.44.mp4

CleanShot 2023-10-25 at 21 22 26@2x

@vercel
Copy link

vercel bot commented Oct 25, 2023

@beerose is attempting to deploy a commit to the Tanstack Team on Vercel.

A member of the Team first needs to authorize it.

@crutchcorn
Copy link
Member

Hey @beerose this is an awesome change! Let's run it past @lachlancollins who's potentially replacing our code embed/highlighter with something new in this PR:

#114

I'll ping him to see if we're good to merge this for now or if we want to wait for a little bit. Either way, we'll for sure add a copy button in the future 😊 Thanks so much for this!

@lachlancollins lachlancollins changed the title add copy to clipboard button to the code block component feat: Add copy to clipboard button to code blocks Jan 9, 2024
@lachlancollins lachlancollins merged commit dec72dd into TanStack:main Jan 9, 2024
2 of 3 checks passed
@beerose beerose deleted the copy-code branch January 9, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants