Skip to content

Commit

Permalink
fix(react-form): update the name of the rendered field when it changes
Browse files Browse the repository at this point in the history
  • Loading branch information
fulopkovacs committed Jan 4, 2025
1 parent 3e88918 commit 673145d
Show file tree
Hide file tree
Showing 2 changed files with 97 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/form-core/src/FieldApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,7 @@ export class FieldApi<
}

this.options = opts as never
this.name = opts.name
}

/**
Expand Down
96 changes: 96 additions & 0 deletions packages/react-form/tests/useField.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,102 @@ describe('useField', () => {
expect(queryByText(onBlurError)).toBeInTheDocument()
})

it('should properly update conditionally rendered fields', async () => {
type FormValues = {
firstField: string
secondField: string
showFirstField: boolean
}

function Comp() {
const form = useForm({
defaultValues: {
firstField: '',
secondField: '',
showFirstField: true,
} as FormValues,
})

return (
<>
<form.Field name="showFirstField">
{({ handleChange, state }) => (
<div>
<span>Show first field</span>
<input
data-testid="show-first-field"
checked={state.value}
type="checkbox"
onChange={(e) => {
// uncomment to fix
// if (e.target.checked) {
// form.deleteField('secondField');
// } else {
// form.deleteField('firstField');
// }
handleChange(e.target.checked)
}}
/>
</div>
)}
</form.Field>
<form.Subscribe selector={(state) => state.values.showFirstField}>
{(someFlagChecked) => {
if (someFlagChecked) {
return (
<form.Field name="firstField">
{({ handleChange, state }) => (
<label>
first field
<input
data-testid="first-field"
value={state.value}
onChange={(e) => handleChange(e.target.value)}
/>
</label>
)}
</form.Field>
)
}

// comment that return to fix it.
return (
<form.Field name="secondField">
{({ handleChange, state }) => (
<label>
second field
<input
data-testid="second-field"
value={state.value}
onChange={(e) => handleChange(e.target.value)}
/>
</label>
)}
</form.Field>
)
}}
</form.Subscribe>
</>
)
}

const { getByTestId } = render(<Comp />)

const showFirstFieldInput = getByTestId('show-first-field')

await user.type(getByTestId('first-field'), 'hello')
expect((getByTestId('first-field') as HTMLInputElement).value).toBe('hello')

await user.click(showFirstFieldInput)
await user.type(getByTestId('second-field'), 'world')
expect((getByTestId('second-field') as HTMLInputElement).value).toBe(
'world',
)

await user.click(showFirstFieldInput)
expect((getByTestId('first-field') as HTMLInputElement).value).toBe('hello')
})

it('should validate async on change', async () => {
type Person = {
firstName: string
Expand Down

0 comments on commit 673145d

Please sign in to comment.