Add wizard / UI to generate multiple tutorials & users at once #381

Dudrie · 2020-05-29T15:40:27Z

🎫 Description

This PR implements the neccessary steps to support the easy generation of multiple users & multiple tutorials.

Server side changes

Add /tutorial/generate@POST route which generates multiple tutorials (only accessible by admins).
Add /user/generate@POST route which creates multiple users based on the given DTOs (only accessible by admins).

Client side changes

Add UI to generate multiple tutorials at once inside the TutorialManagement view.
Add UI/wizard to import user data in CSV form to create multiple users at once.
Add keyboard support for all DatePickers & TimePickers in the whole app.
Change SheetSelector to show a loading indicator while loading sheets from the server.

🔒 Closes

Closes Automatically create users & tutorials #346
Closes Import Users from CSV file #38

This pipe uses the class-transformer options and does validate the incoming object before (!) converting it to a class with the NestJS' build in ValidationPipe.

This takes in the DTO and generates multiple tutorials according to the provided information. Returns all created tutorials.

This is a first draft of the component which gets adjusted as needed.

All "children" (ie step components) can now use some functionalities provided by a special context. These functionalities can be used to customize when and if the "Next-Button" actually resolves it's action (ie waiting for a fetch with moving forward if the fetch was successful).

This is without functionality and TabPanels for the weekdays, yet.

This splits up the code into several smaller components.

This also adds sorting of the excluded dates / intervals. Intervals take their starting (!) date for sorting.

This shows a simple "yes/no"-Dialog with customizable button labels aswell as title and content. The showConfirmationDialog returns a Promise<boolean> which is true if the user clicked "yes" and false in all other cases.

This would allow to display row-specific errors later.

This tries to map slot names to existing tutorials. If they match the tutorial's ID is added to the form data of that user.

This lets the user choose a .csv file. If "valid" (against a simple MIME type check) the content of the file will be set as csvInput - if later will be overridden by this action the user has to confirm the override.

This makes it easier to access different types of snackbares from one hook (normal, error or with list). Additionally a new useSnackbarWithList() hook was added to ease the process of creating a SnackbarWithList.

Related components are those which either use the SnackbarWithList component or which previously used both hooks: useSnackbar() and useErrorSnackbar(). This reduces the code for all components that use the SnackbarWithList component about a few lines.

This changes the return type to an array of object s which can include a value or an error message each. This way the user can be informed about which users where created and which were not (due to failure).

Now, the tests check if the correct ValueOrError object gets returned with the anticipated error message.

This basicly reverts the previous change but with the addition of deleting all created users before throwing the error. This effectively reverts the DB back into it's state before the request.

SelectInterval: Fix not propagating invalid intervals properly if start or end date are "null". If one of those are "null" an invalid Interval with a corresponding message is created and set as value. WeekdayBox: Sorting failed if one of the intervals where invalid. Now, invalid intervals get sorted to the top of the list.

Dudrie added 🌟 enhancement New feature or request 🗄 server Issue is related to the sever 💻 client Issue is related to the client 🎆 QOL Issue is related to a quality of life improvment labels May 29, 2020

Dudrie self-assigned this May 29, 2020

Dudrie force-pushed the issue-346-Automatically_create_users_tutorials branch from 2d12efa to b318e2c Compare May 29, 2020 15:41

Dudrie force-pushed the issue-346-Automatically_create_users_tutorials branch from e1e4de2 to 5b8e98c Compare June 1, 2020 14:19

Dudrie added 22 commits June 8, 2020 14:13

Add pipe which automatically transform parameter objects.

548ad4d

This pipe uses the class-transformer options and does validate the incoming object before (!) converting it to a class with the NestJS' build in ValidationPipe.

Add validator for luxon Interval objects.

028cf60

Add /tutorial/generate POST path to generate multiple tutorials.

8a49aa0

This takes in the DTO and generates multiple tutorials according to the provided information. Returns all created tutorials.

Add first part of tests for tutorial generation.

ee675ad

Add assertion between generation data and generated tutorials.

e2066dd

Fix generating tutorials without dates.

bef02dd

Add more tests related to tutorial generation.

99b8694

Add assertion that generated tutorials have at least one date.

59c9835

Add function to UserService to create multiple users with one request.

139ee47

Add path /user/generate (POST) to generate multiple users.

7fc2b59

Add tests for creating multiple users at once.

ef90ac3

Fix wrong craco config in dev environment.

aa28108

Add new route to the import component.

093e2a8

Add a StepperWithButtons component (WIP).

208db00

This is a first draft of the component which gets adjusted as needed.

Remove unneccessary usage of "React.useState" with "useState".

408a1cc

Change general layout structure of StepperWithButtons.

7dec09b

Add general layout of GenerateTutorials component.

c9d61d9

This is without functionality and TabPanels for the weekdays, yet.

Add function to disable the next button [StepperWithButtons]

ec3d6ef

Refactor GenerateTutorials & related components.

2a1670e

This splits up the code into several smaller components.

Fix odd layout on GenerateTutorials.

5717905

Add logic to exclude dates & intervals.

b66f231

This also adds sorting of the excluded dates / intervals. Intervals take their starting (!) date for sorting.

Dudrie added 24 commits June 23, 2020 19:25

Add showConfirmationDialog to useDialog.

59405e1

This shows a simple "yes/no"-Dialog with customizable button labels aswell as title and content. The showConfirmationDialog returns a Promise<boolean> which is true if the user clicked "yes" and false in all other cases.

Add confirmation before resetting the generation datas of one user.

680d146

Change FormikFilterableSelect to use useField.

12edbe0

Change "id" in CSVDataRow to "rowNr".

2c868f2

This would allow to display row-specific errors later.

Add selection and parsing for tutorials from CSV.

68b8617

This tries to map slot names to existing tutorials. If they match the tutorial's ID is added to the form data of that user.

Refactor EditUserDialog to be it's own component.

8e1db2c

Add time information to tutorial selection items.

e966d75

Change MapCSVColumns UI to clean it up.

41b6f5a

Add sort button to WeekdayBox to sort slot information by starttime.

51779d2

Add upload button to ImportUserCSV.

6de5c7a

This lets the user choose a .csv file. If "valid" (against a simple MIME type check) the content of the file will be set as csvInput - if later will be overridden by this action the user has to confirm the override.

Fix tutorials not deleting associated teams.

f5e1d22

Add shortcut (ctrl+Enter) to ImportUserCSV to call nextStep.

413fba3

Change SheetSelector to actually use the isLoadingSheet prop.

86740ea

Add useCustomSnackbar hook.

cbba5c1

This makes it easier to access different types of snackbares from one hook (normal, error or with list). Additionally a new useSnackbarWithList() hook was added to ease the process of creating a SnackbarWithList.

Change POST:/user/generate to return errors if neccessary.

610560a

This changes the return type to an array of object s which can include a value or an error message each. This way the user can be informed about which users where created and which were not (due to failure).

FIx wrong types in UserController and tests.

e900a12

Fix failing test due to obsolete implementation.

acbce54

Now, the tests check if the correct ValueOrError object gets returned with the anticipated error message.

Change POST:/user/generate to throw BadRequestError again.

73a1eb7

This basicly reverts the previous change but with the addition of deleting all created users before throwing the error. This effectively reverts the DB back into it's state before the request.

Change client to also comply to the reverted /user/generate commit.

c484fe9

Change helperText on seperator textfield on ImportCSV.

6bdd6d5

Remove unused variable.

1cdcae1

Merge branch 'v2' into issue-346-Automatically_create_users_tutorials

9f553c4

Dudrie marked this pull request as ready for review June 26, 2020 13:55

Dudrie merged commit 993767b into v2 Jun 26, 2020

Dudrie deleted the issue-346-Automatically_create_users_tutorials branch June 26, 2020 16:09

This was referenced Jul 11, 2020

On tutorial creation the admin should have more configuring options #256

Closed

Quality of life changes #12

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wizard / UI to generate multiple tutorials & users at once #381

Add wizard / UI to generate multiple tutorials & users at once #381

Dudrie commented May 29, 2020 •

edited

Loading

Add wizard / UI to generate multiple tutorials & users at once #381

Add wizard / UI to generate multiple tutorials & users at once #381

Conversation

Dudrie commented May 29, 2020 • edited Loading

🎫 Description

Server side changes

Client side changes

🔒 Closes

Dudrie commented May 29, 2020 •

edited

Loading