Merge pull request #953 from Dudrie/fix-short-test-passed-state-not-c…

…orrect Fix wrong calculation of short test passed state.
TMS-Uni-Stuttgart · Mar 1, 2021 · c6548ba · c6548ba
2 parents c536fb8 + 454bdb9
commit c6548ba
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/server/src/module/scheincriteria/container/criterias/ShortTestCriteria.ts b/server/src/module/scheincriteria/container/criterias/ShortTestCriteria.ts
@@ -73,16 +73,9 @@ export class ShortTestCriteria extends PossiblePercentageCriteria {
                 const achieved = student.getGrading(shortTest)?.points ?? 0;
                 const total = shortTest.totalPoints.must;
 
-                let state = PassedState.NOT_PASSED;
-                if (this.isPercentagePerTest) {
-                    if (shortTest.hasPassed(student)) {
-                        state = PassedState.PASSED;
-                    }
-                } else {
-                    if (achieved >= this.valuePerTestNeeded) {
-                        state = PassedState.PASSED;
-                    }
-                }
+                const state = shortTest.hasPassed(student)
+                    ? PassedState.PASSED
+                    : PassedState.NOT_PASSED;
 
                 return {
                     passed: state === PassedState.PASSED ? prev.passed + 1 : prev.passed,