Remove duplicate type "StudentScheinCriteriaSummaryMap"

client/src/hooks/fetching/Tutorial.ts

@@ -1,10 +1,10 @@
+import { ScheincriteriaSummaryByStudents } from 'shared/dist/model/ScheinCriteria';
 import { Student } from 'shared/dist/model/Student';
 import { SubstituteDTO, Tutorial, TutorialDTO } from 'shared/dist/model/Tutorial';
 import { TutorInfo, User } from 'shared/dist/model/User';
 import { sortByName } from 'shared/dist/util/helpers';
 import {
   StudentByTutorialSlotSummaryMap,
-  StudentScheinCriteriaSummaryMap,
   TutorialWithFetchedCorrectors,
   TutorialWithFetchedStudents,
   TutorialWithFetchedTutor,
@@ -192,8 +192,8 @@ export async function getStudentsOfTutorial(id: string): Promise<Student[]> {
 
 export async function getScheinCriteriaSummariesOfAllStudentsOfTutorial(
   id: string
-): Promise<StudentScheinCriteriaSummaryMap> {
-  const response = await axios.get<StudentScheinCriteriaSummaryMap>(
+): Promise<ScheincriteriaSummaryByStudents> {
+  const response = await axios.get<ScheincriteriaSummaryByStudents>(
     `scheincriteria/tutorial/${id}`
   );
 

client/src/typings/types.ts

@@ -31,10 +31,6 @@ export interface HasPoints extends HasId {
   points: PointMapDTO;
 }
 
-export interface StudentScheinCriteriaSummaryMap {
-  [id: string]: ScheinCriteriaSummary;
-}
-
 export interface StudentByTutorialSlotSummaryMap {
   [tutorialSlot: string]: ScheinCriteriaSummary[];
 }

client/src/view/dashboard/Dashboard.tsx

@@ -1,22 +1,20 @@
 import React, { useEffect, useState } from 'react';
 import { Role } from 'shared/dist/model/Role';
+import { ScheincriteriaSummaryByStudents } from 'shared/dist/model/ScheinCriteria';
 import { Tutorial } from 'shared/dist/model/Tutorial';
 import { LoggedInUser } from 'shared/dist/model/User';
 import LoadingSpinner from '../../components/loading/LoadingSpinner';
 import { getTutorial } from '../../hooks/fetching/Tutorial';
 import { useAxios } from '../../hooks/FetchingService';
 import { useLogin } from '../../hooks/LoginService';
-import {
-  StudentByTutorialSlotSummaryMap,
-  StudentScheinCriteriaSummaryMap,
-} from '../../typings/types';
+import { StudentByTutorialSlotSummaryMap } from '../../typings/types';
 import AdminStatsCard from './components/AdminStatsCard';
 import AllTutorialStatistics from './components/AllTutorialStatistics';
 import TutorialStatistics from './components/TutorialStatistics';
 
 export interface TutorialSummaryInfo {
   tutorial: Tutorial;
-  studentInfos: StudentScheinCriteriaSummaryMap;
+  studentInfos: ScheincriteriaSummaryByStudents;
 }
 
 function isAdmin(userData: LoggedInUser | undefined): boolean {