Task/tup 534 auto get correct data col value #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Tomas-Gonzalez
approved these changes
Nov 30, 2023
wesleyboar
added a commit
that referenced
this pull request
Jan 25, 2024
* task/tup-534 Adds in media query for tables * adds in data attributes to each col. Isn't right just yet. Specifically not working for nested tables just yet. Also, need to look at paragraph tables with no headers - padding adjusts for headers even when there are none... * removes number from data-col attributes. ie. data-col-(number). * Task/tup 534 auto get correct data col value (#277) * test: get correct data-col value (INCOMPLETE) * feat: get correct col names & values (INCOMPLETE) * feat: get correct col names & values (SUCCESS) * chore: clean up new helper getColFromRow * refactor: less chars in hbs, more logic in config * fix: remove cruft change * chore: remove console.log * fix: missing cols breaks getColFromRow * chore: simplify previous fix * added in all styles. Need to check on borders. worked on fractal. * made changes for nested tables * Adjusted borders (at least for now) on all tables. * includes all basic adjustments accomplishes 1 - 3 on design dev mtg notes.(will attach comments). * removes border-top:none. Temporarily removes table truncation. * tier one. adjusting and cleaning up all borders. we can adjust from here when/if needed. But for now, they are mimiced from desktop to mobile * tier 2. Nested Tablesssss. * tier 3. Table cleanup after subsequent meeting with design Awaiting design for feedback on nested tables. * making review changes * reverting weird formatting changes * updating to match more reviews removing commented out code in fractal. commenting out correct table truncation * docs: revert mismatched comment * Removal of trump tables. Removal of truncated css. * fix: restore s-paragraph-table (removed in 0a9b0b6) This table is a Trump (Scope) pattern used by CMS. It is loaded by table to keep code DRY, but it should appear in Trumps section of demo. I welcome discussion of different solutions. This is not the only such case like this. P.S. The s-truncated-table was removed in 0a9b0b6 also. That's expected. No clients use it. If they want truncation, they can use Core-Styles truncation or do it themselves. * nested table color change * add in styles to match design * style: remove excess spaces * fix: restore erroneously deleted code * fix: remove unused styles peer-programmed with T.G. to confirm Note: one style W.B. thought should go was retained because it does soemthing: table.has-table { & tr :is(td,th):last-child { border-bottom: unset; } } * make adjustments to resolve comments * fix: restore html-elements.cms.css in docs css --------- Co-authored-by: Wesley B <[email protected]> Co-authored-by: Wesley Bomar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Get correct
data-colvalue by using a helper function.Related
Changes
data-colvalues to use functionTesting
UI
Notes
I welcome (beg for) solutions to reduce the verbosity in templates.