feat/tup-648 Migrate u-highlight from tup-ui to core-stlyes #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Tomas-Gonzalez
added
feature
wesleyboar
reviewed
Nov 15, 2023
Co-authored-by: Wesley B <[email protected]>
wesleyboar
requested changes
Nov 15, 2023
There was a problem hiding this comment.
The .tag… class and <figure> seem superfluous to demo-ing u-highlight.
I propose:
A. removing them
B. making them part of an additional example of the u-highlight (e.g. a use case / context), where the first example is just a u-highlight… something basic1
C. any idea you wanna try or brainstorm
Footnotes
wesleyboar
reviewed
Nov 16, 2023
added u-highlight container max-width, and u-highlight padding-inline.
wesleyboar
approved these changes
Nov 16, 2023
wesleyboar
deleted the
feat/tup-648-migrate-u-hightlight-to-core-styles
branch
R-Tomas-Gonzalez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added demo and style for u-highlight.
Note! Must change
Related
Changes
Adds u-highlight to core-styles
Testing
UI