Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tup-636 c-card--image - less templates #257

Merged
merged 20 commits into from
Nov 17, 2023
Merged

chore: tup-636 c-card--image - less templates #257

merged 20 commits into from
Nov 17, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 8, 2023 •
edited
Loading

Overview

Use less templates for c-card--image-… demo.

Related

Changes

  • changed card image demo to use less templates
  • deleted card image templates that are replaced
  • changed card image config to explicitly set status

Testing

  1. Review c-card--images demo on feat/tup-636-c-card--images-migration.
  2. Review c-card--images demo on feat/tup-636-c-card--images-migration--less-templates.
  3. Layout should be unchanged.
  4. Images (except contact card) have changed.
  5. All image-right or image-left cards have a warning about narrow images.

UI

full-height screenshot

full-height screenshot

R-Tomas-Gonzalez and others added 14 commits November 1, 2023 15:46
@R-Tomas-Gonzalez
adding image cards to demo
a30f65a
@R-Tomas-Gonzalez
adds in all section colors. adds in styles for demo
3f741ed
@R-Tomas-Gonzalez
Remove duplicate code from c-card--from-tup-cms.css pertaining to car…
ff4d999 
…d--images. Removed _c-card--one-image.hbs file.
@R-Tomas-Gonzalez
Merge branch 'main' into feat/tup-636-c-card--images-migration
ea85084
@R-Tomas-Gonzalez
resolved conflicts
86b0700
@wesleyboar
consistent 5-line space between different contexts
3f0b386 
https://confluence.tacc.utexas.edu/x/SQALBg#UICSSStyleGuideWhitespace&Organization-MeaningfulWhitespace
@R-Tomas-Gonzalez
merge main into core-styles
58ca272
@R-Tomas-Gonzalez
added in build dist files - just in case
eb6d659
@wesleyboar
fix: remove import of deleted file
ee549dc
@wesleyboar
style: restore final NL in file (to reduce diff)
7ecd880
@wesleyboar
style: remvoe excess whitespace
3450df4
@R-Tomas-Gonzalez
creating more files to make card--images dynamic
c4cf3ec
@R-Tomas-Gonzalez
Merge branch 'main' into feat/tup-636-c-card--images-migration
f78eed2
@wesleyboar
chore: tup-636 c-card--image w/ less templates
0ee90fc
@github-actions github-actions bot added the feature A new feature or replacement of existing feature label Nov 8, 2023
@wesleyboar wesleyboar added the patch A backward-compatible fix label Nov 8, 2023
Base automatically changed from feat/tup-636-c-card--images-migration to main November 8, 2023 21:55
@wesleyboar wesleyboar added refactor Re-writes/structures code but retains behavior and removed feature A new feature or replacement of existing feature labels Nov 17, 2023
@wesleyboar wesleyboar merged commit dddb8c4 into main Nov 17, 2023
@wesleyboar wesleyboar deleted the feat/tup-636-c-card--images-migration--less-templates branch November 17, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Tomas-Gonzalez R-Tomas-Gonzalez R-Tomas-Gonzalez approved these changes

Assignees
No one assigned
Labels
patch A backward-compatible fix refactor Re-writes/structures code but retains behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @R-Tomas-Gonzalez