Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WP-68: Update DataFiles Unit Tests #992

Merged
merged 23 commits into from
Dec 5, 2024

Conversation

jalowe13
Copy link
Collaborator

@jalowe13 jalowe13 commented Nov 4, 2024

Overview

Updating unit tests and fixtures for DataFiles for both front-end and back-end functions.

Improving backend test coverage to have all files in the datafiles folder to be 75% covered or more
Code coverage before

Code coverage after

Related

Changes

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.85%. Comparing base (51e2230) to head (45e6299).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   72.71%   72.85%   +0.13%     
==========================================
  Files         534      534              
  Lines       33564    33581      +17     
  Branches     2984     2988       +4     
==========================================
+ Hits        24407    24464      +57     
+ Misses       8962     8919      -43     
- Partials      195      198       +3     
Flag Coverage Δ
javascript 75.61% <100.00%> (+0.07%) ⬆️
unittests 60.84% <100.00%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ts/DataFiles/fixtures/DataFiles.systems.fixture.js 100.00% <100.00%> (ø)
server/portal/apps/datafiles/views.py 75.67% <100.00%> (+9.18%) ⬆️

... and 4 files with indirect coverage changes

@jalowe13 jalowe13 marked this pull request as ready for review November 20, 2024 22:55
@jalowe13
Copy link
Collaborator Author

Ready for review!

@rstijerina rstijerina merged commit 84d30e5 into main Dec 5, 2024
6 checks passed
@rstijerina rstijerina deleted the task/WP-68--datafiles-unit-test-update branch December 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants