Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-97: Fix skipped unit tests: TestAgaveUtils#test_walk_levels #926

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

chandra-tacc
Copy link
Collaborator

Overview

Cleaning up skipped tests

Related

Changes

  • Adapt to Tapis api changes

Testing

  1. pytest -ra portal/libs/agave/

UI

Notes

Fix TestAgaveUtils#test_walk_levels
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b4abc6) 63.54% compared to head (ba4d1ef) 63.70%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
+ Coverage   63.54%   63.70%   +0.15%     
==========================================
  Files         431      431              
  Lines       12433    12433              
  Branches     2594     2594              
==========================================
+ Hits         7901     7920      +19     
+ Misses       4315     4292      -23     
- Partials      217      221       +4     
Flag Coverage Δ
javascript 69.81% <ø> (ø)
unittests 57.48% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@chandra-tacc chandra-tacc marked this pull request as ready for review December 21, 2023 17:58
Copy link
Contributor

@shayanaijaz shayanaijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Test looks to be running fine

@asimregmi
Copy link
Contributor

LGTM

@chandra-tacc chandra-tacc merged commit 7fd106f into main Dec 21, 2023
6 checks passed
@chandra-tacc chandra-tacc deleted the bug/WP-97-fix-skipped-tests branch December 21, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants