Bug/wp 47 fix shared workspace manage team modal

[van-go]

Overview

In 'Shared Workspace':

1. if user is a GUEST, disable 'Rename' and 'Trash' buttons
2. change button style for 'Update' button to match toolbar

Related

• WP-47

Changes

1. In DataFilesToolbar.jsx: created an 'isGuest' field which uses the authenticatedUserQuery to determine if a user is a guest. canRename and canTrash check isGuest; if that is True, then those buttons are disabled.
2. In SystemRoleSelector.jsx: changed the button import to come from _common. Added a left margin to the css (DataFilesProjectMembers.module.scss)

Testing

1. Login as a guest, go to a Data Files > Shared Workspace, verify that the 'Rename' and 'Trash' buttons are disabled.
2. Login normally, edit the Team Members for a Shared Workspace, verify the button is matches the buttons in the toolbar and turns purple when rolled over.

UI

Disable 'Rename' and 'Trash' for Guest
https://github.com/TACC/Core-Portal/assets/35277477/b41396be-86bc-4d2a-80ae-fadeaff350c5

changes to 'Update' button

Notes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fd106f) 63.70% compared to head (14acb22) 63.71%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   63.70%   63.71%   +0.01%     
==========================================
  Files         431      431              
  Lines       12433    12438       +5     
  Branches     2594     2597       +3     
==========================================
+ Hits         7920     7925       +5     
  Misses       4292     4292              
  Partials      221      221              

Flag	Coverage Δ
javascript	69.83% <100.00%> (+0.02%)	⬆️
unittests	57.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...aFilesProjectMembers/_cells/SystemRoleSelector.jsx	71.11% <ø> (ø)
...ts/DataFiles/DataFilesToolbar/DataFilesToolbar.jsx	76.85% <100.00%> (+1.12%)	⬆️

[shayanaijaz]

Functionality works as expected. Currently the move task also fails as a guest user. I think the move button also needs to be disabled since a user cannot do a move operation when they don't have modify permissions on files.

[edmondsgarrett]

LGTM! Thanks for updating those unit tests as well

[van-go]

@shayanaijaz I added the same 'isGuest' check to the move function. Guest users can no longer move files. The button is disabled for Guest users.

[shayanaijaz]

LGTM. Thanks for the additions