WP-59: Reload app page after every navigation

[asimregmi]

Overview

After job submission, the success message will hang at the top of the screen even if you navigate away and back to the app (without refreshing the browser).

Direction
To replicate:

1. submit a job (i.e. paraview)
2. Click the "Allocations" button on the left hand sidebar
3. Go back to the "Applications" view on the left hand sidebar
4. Click Visualization -> Paraview
   

Related

• WP-59

Changes

• added a useEffect and useHistory to listen for navigation changes and reset the jobSubmission properties
• removed logic to not reload an app if it's already currentApp exists

  Core-Portal/client/src/redux/sagas/apps.sagas.js

  Lines 23 to 27 in 6bfc782

  	if (
  	currentApp.definition.id === appId &&
  	currentApp.definition.version === appVersion &&
  	!currentApp.systemNeedsKeys
  	) {

Testing

1. Submit paraview job and navigate to allocations and go back to the paraview app. The message should go away.
2. Confirm other error message still shows and doesn't go away (for example the Matlab license in the screenshot below)

UI

Message reset after changing tabs

Other error message still renders correctly

Notes

I investigated this behavior and have included comment on why this might be happening on the Jira ticket WP-59. Sal mentioned other solution which might work - "It may be possible to only use get_app, but we'll need to ensure we can handle the request properly on the backend to look for html in the database for the app record instead of sending a request to tapis for html apps." I tried other methods to reset the message after app loads successfully, added a useEffect hook for LOAD_APP & GET_APP dispatchers but this solution seemed to work the best.

Update:
After suggestions from Sal, I updated the logic on app.sagas.js to reload an app everytime it is clicked so the issue above issue is solved.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (272c632) 63.49% compared to head (8c86f01) 63.52%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   63.49%   63.52%   +0.03%     
==========================================
  Files         431      431              
  Lines       12430    12424       -6     
  Branches     2595     2591       -4     
==========================================
  Hits         7892     7892              
+ Misses       4322     4317       -5     
+ Partials      216      215       -1     

Flag	Coverage Δ
javascript	69.81% <ø> (+0.06%)	⬆️
unittests	57.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...nt/src/components/Applications/AppForm/AppForm.jsx	84.08% <ø> (ø)
client/src/redux/sagas/apps.sagas.js	22.22% <ø> (+4.04%)	⬆️

[rstijerina]

LGTM!

[shayanaijaz]

LGTM