Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-388: Handle text overflow on longer system labels(systemName) #901

Merged
merged 3 commits into from
Nov 20, 2023
Merged

task/WP-388: Handle text overflow on longer system labels(systemName) #901

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8f8909
fixed text overflow for longer system labels(systemName)
Nov 15, 2023
2ec14bb
added auto-width css
Nov 15, 2023
8654a0e
Merge branch 'main' into task/WP-388-systemName-overflow-fix
rstijerina Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/src/styles/components/dropdown-menu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ Styleguide Components.Dropdown
border-radius: 0;
margin-top: 11px;
padding: 0;
width: 200px;
min-width: 200px;
width: auto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a max-width, for very long folder names?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path folder names won't be an issue bc they're being restricted to 20 chars. So it would only be an issue with system names/labels. My thinking is if we include a max-width the text overflow would happen again with a long system name. I know there's already code in the css file to handle media/device screen size rules. Do we think that's enough to handle the potential issue, or should I add a max-width of 800px and assume we'd never have a super long system name label past that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah perfect, I think this is a good solution to this problem. Very long system names are unlikely, but we could address that in another task if need be.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

vertical-align: top;
}
.dropdown-menu::before,
Expand Down