Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/WP-271 Upgrade Django to 4.2 and update other 3rd party dependencies #895
task/WP-271 Upgrade Django to 4.2 and update other 3rd party dependencies #895
Changes from 6 commits
7c46c48
5ce7673
f1c7e87
06a732d
aa53b6a
9388172
06e0e7e
65f28e4
5c72528
bdb2a02
e42301d
ab25428
4aabeab
59e92a9
31448ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: https://channels.readthedocs.io/en/stable/releases/3.0.0.html#update-to-asgi-3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: https://channels.readthedocs.io/en/stable/releases/3.0.0.html#deprecations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do websocket notifications work without defining a mapping for
"websocket"
in theProtocolTypeRouter
? https://channels.readthedocs.io/en/latest/topics/routing.html?highlight=protocoltyperouter#protocoltyperouterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The websocket mapping is defined in routing.py and from my testing notifications are working fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: https://channels.readthedocs.io/en/stable/releases/4.0.0.html#decoupling-of-the-daphne-application-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to filter a couple of warnings.
twisted
package has a PR open currently to address the cgi deprecation warning