Bug/WP-779--[Regression] File preview is smaller compared to production #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
=======================================
Coverage 72.68% 72.68%
=======================================
Files 534 534
Lines 33657 33656 -1
Branches 2989 2989
=======================================
Hits 24464 24464
+ Misses 8995 8994 -1
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wesleyboar
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks. This Bootstrap v5 breaking change is documented. I've added a link to it in the PR description as a footnote. I create a ticket, WP-812, for other relevant breaking changes.
wesleyboar
previously requested changes
Dec 9, 2024
There was a problem hiding this comment.
Good find. Note: Based on documentation, this [instance of updating] to v5 classes is incomplete.
client/src/components/DataFiles/DataFilesModals/DataFilesPreviewModal.jsx
Show resolved
Hide resolved
wesleyboar
approved these changes
Dec 9, 2024
fnets
approved these changes
Dec 9, 2024
chandra-tacc
deleted the
bug/WP-779--File-preview-is-smaller-compared-to-production
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
File preview is smaller compared to production
Related
Changes
Testing
UI
Before
After
Production
Notes
Footnotes
"Responsive embed helpers [renamed]" ↩