Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/wg 403 create asset geometry component #295

Merged
merged 11 commits into from
Jan 8, 2025

Conversation

sophia-massie
Copy link
Contributor

@sophia-massie sophia-massie commented Dec 18, 2024

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Adds Asset Geometry component to mimic the behavior in angular

Testing Steps:

  1. Set your local env to production
  2. Go to test_project_testen Map
  3. Click through the various types of Geometries (Point, Geometry Collection, Polygon, MultiPolygon etc) and make sure they appear like test_project_testen Prod Map
  4. Test other maps with images, video, point clouds etc and check that the Geometry metadata appears as expected and compare with prod

UI Photos:

Polygon:

Screenshot 2024-12-17 at 9 12 37 PM

Line String

Screenshot 2024-12-17 at 9 13 15 PM

Point LOL at the pic

Screenshot 2024-12-17 at 9 13 53 PM

Geometry Collection

Screenshot 2024-12-17 at 9 14 28 PM

Notes:

overflow-x: hidden;
justify-items: flex-end;
align-items: flex-end;
width: 100%;
}
.metadataTable {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things taken out here were styles that were not being applied by the browser

@sophia-massie sophia-massie marked this pull request as ready for review December 18, 2024 15:29
? turf.bbox(selectedFeature)
: null;

const geometryType: FeatureType = getFeatureType(selectedFeature);
Copy link
Collaborator

@nathanfranklin nathanfranklin Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to

A) keep the variable name and then comment that you are considering only geometry types (subset of FeatureType). 🤔

or maybe:

B) const geometryType = selectedFeature.geometry.type


there is a difference currently with angular version, as here if its an something like an image or video feature, we don't show point coordinates (as its featureType would be image and then not captures by any of the conditional rendering below. but i think would be fixed with approach (B).

(good tests by the way as covers this case well 💯 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I think B works well. This is updated with the latest push

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 just the issue on video + image point features.

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; LGTM 👍

@sophia-massie sophia-massie merged commit dc02685 into main Jan 8, 2025
5 checks passed
@sophia-massie sophia-massie deleted the task/WG-403-Create-Asset-Geometry-Component branch January 8, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants