Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-208 Listing Dropdown #196

Merged
merged 8 commits into from
Mar 15, 2024
Merged

Conversation

shayanaijaz
Copy link
Contributor

@shayanaijaz shayanaijaz commented Jan 18, 2024

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Added a SystemSelect dropdown that shows the user systems available to them
  • Added placeholder for designsafe projects which will be added when useProject hook is avaiable
  • Added a useSystems hook that retrieves designsafe tapis systems
  • Added tests for SystemSelect with sample fixture
  • Add types for tapis System response
  • Added SystemSelect component and event handling to MainMenu for demo purposes

Testing Steps:

  1. Get the react project up and running and go to localhost:4200 to see the SystemSelect dropdown

UI Photos:

Screen Shot 2024-01-19 at 1 44 54 PM Screen Shot 2024-01-19 at 1 45 01 PM

Notes:

TODO:

  • Add Designsafe projects to SystemSelect as well using project hook

@shayanaijaz shayanaijaz marked this pull request as ready for review January 19, 2024 19:50
@shayanaijaz shayanaijaz changed the title tsk/WG-208 Listing Dropdown task/WG-208 Listing Dropdown Jan 19, 2024
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}) => {
const { data: systems } = useSystems();

// use dsProjects hook here
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in angular hazmapper, the systems list was used as all projects start with "projects-". but using the DS projects hook makes more sense 👍

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

can you just merge master? The is a recent changes in request.ts that changed the signature of the useGet in request.ts (now apiService instead of the baseUrl )

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@tjgrafft tjgrafft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shayanaijaz shayanaijaz merged commit 5e4aa09 into master Mar 15, 2024
5 checks passed
@shayanaijaz shayanaijaz deleted the task/WG-208--file-listing-component branch March 15, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants