Use tacc/core-styles #194
Merged
Use tacc/core-styles #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfranklin
commented
Feb 2, 2024
| @@ -7,7 +7,7 @@ | |||
| transition: color var(--transition-duration), | |||
| background-color var(--transition-duration); | |||
|
|
|||
| composes: c-button--secondary from '@tacc/core-styles/src/lib/_imports/components/c-button.css'; | |||
| composes: c-button--secondary from '@tacc/core-styles/dist/components/c-button.css'; | |||
There was a problem hiding this comment.
@wesleyboar, @tjgrafft , @sophia-massie This was causing the errors we were seeing; so should make its way back to TUP and/or the future core-components package:
GET http://localhost:4200/tools/x-truncate.css net::ERR_ABORTED 404 (Not Found)
GET http://localhost:4200/objects/o-section.selectors.css net::ERR_ABORTED 404 (Not Found)
GET http://localhost:4200/tools/x-link.css net::ERR_ABORTED 404 (Not Found)
GET http://localhost:4200/c-button.selectors.css net::ERR_ABORTED 404 (Not Found)
There was a problem hiding this comment.
Thanks, yes. Bug in TUP. The /dist/ is preferred unless one need do something advanced.
tjgrafft
approved these changes
Feb 5, 2024
wesleyboar
approved these changes
Feb 6, 2024
| @@ -7,7 +7,7 @@ | |||
| transition: color var(--transition-duration), | |||
| background-color var(--transition-duration); | |||
|
|
|||
| composes: c-button--secondary from '@tacc/core-styles/src/lib/_imports/components/c-button.css'; | |||
| composes: c-button--secondary from '@tacc/core-styles/dist/components/c-button.css'; | |||
There was a problem hiding this comment.
Thanks, yes. Bug in TUP. The /dist/ is preferred unless one need do something advanced.
wesleyboar
requested changes
Feb 6, 2024
There was a problem hiding this comment.
That new line before layer(foundation) worries me enough to reconsider merge. Please check #194 (comment). I don't want y'all to have to fight Bootstrap because of a typo.
Co-authored-by: Wesley B <[email protected]>
wesleyboar
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Add core styles.
Input from Wes from meeting https://tacc-main.atlassian.net/wiki/spaces/DES/pages/43384853/2024-01-25+Meeting+notes
PR Status: