Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop all redirections, and comment heavily #367

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

bruberu
Copy link
Member

@bruberu bruberu commented Jan 7, 2025

Fixes SymmetricDevs/Supersymmetry#1214.

Apparently, GTTransferUtils (and probably other transfer methods) base how much they will transfer off of the number of items inserted in the simulation phase. Given that they insert into many different slots during this simulation, we cannot have those insertions redirected to the same slot, or else it will appear as if that one slot can just accept all of that.

Copy link
Collaborator

@MCTian-mi MCTian-mi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and this works for me
gj beru!

@bruberu bruberu merged commit f3111b7 into main Jan 7, 2025
1 check passed
@bruberu bruberu deleted the urgently-fixing-restrictive-filter branch January 7, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠Urgent⚠ The restrictive filter is voiding items
2 participants