Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incinerator multiblock #286

Conversation

The-Minecraft-Scientist
Copy link
Contributor

@The-Minecraft-Scientist The-Minecraft-Scientist commented Aug 11, 2024

This provides a basic code implementation (and multiblock structure) for #285.
Tentatively called the Incinerator but will likely be renamed to whatever name fits the final structure.
Currently the multi does not consume power, but could be modified to do so if needed.

Points to work out

  • Decide on a final structure/design (current one is more to avoid bikeshedding than anything else)
  • Balance
    • Should it use power?
    • How expensive should it be? (related to structure/design)
    • How will the tiering (if any) work?
  • Remove as many remaining automated item voiding methods as possible

(this PR also renames VoidingMultiblockBase toFluidVoidingMultiblockBase to fit in with ItemVoidingMultiblockBase).

FYI, I have done zero 1.12 modding, so please let me know if I footgun myself/otherwise write bad/wrong code

@The-Minecraft-Scientist The-Minecraft-Scientist marked this pull request as ready for review August 15, 2024 07:12
@The-Minecraft-Scientist
Copy link
Contributor Author

The-Minecraft-Scientist commented Aug 15, 2024

Current state:
Multiblock does not consume power. gated behind aluminium (frame boxes).
It voids one item per tick for free, and up to an unlimited number of items per tick with boosting

You can boost the incinerator by giving it all of the inputs of a Large Gas Turbine recipe (just no lubricant because why would you lubricate a box that burns stuff). When boosted, the incinerator voids additional items every cycle (in addition to the free 1 item per tick) at a rate of one item per 10,000 EU generated by the fuel (note that oxidizers are still taken into account, it uses the SuSy LGT recipe map to compute this eu value). It will currently consume as much fuel as possible each cycle (essentially uncapping the boosted voiding rate), but that could easily be capped if there are balance concerns (in addition to changing the EU cost of voiding one item)

@The-Minecraft-Scientist
Copy link
Contributor Author

Going to close this PR because the direction that was decided on for item voiding doesn't align with the code very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants