Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Phone #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[WIP] Phone #17

wants to merge 6 commits into from

Conversation

harihitode
Copy link
Contributor

Putting the "Apple Script" on Assets/script.
I don't know whether it is good place.

@natezzz
Copy link
Contributor

natezzz commented Dec 2, 2015

~~@natezzz ops! sorry. this is a wrong file. this request is not correct. thanks~~~ (updated by accident)

@takuti takuti changed the title Phone [WIP] Phone Dec 2, 2015
@takuti takuti added this to the Unity Phone App Implementation milestone Dec 2, 2015
@takuti takuti added the Unity label Dec 2, 2015
@harihitode
Copy link
Contributor Author

excuse me. perhaps I updated nate's comment?

@natezzz
Copy link
Contributor

natezzz commented Dec 2, 2015

yeah...

@harihitode
Copy link
Contributor Author

oh god. actually, this is my first time using this web site. Ok. I've got it now.

@takuti
Copy link
Contributor

takuti commented Dec 2, 2015

@harihitode You do not need to close the pull request. If you pushed wrong commits, you can fix them as:

@harihitode
Copy link
Contributor Author

ok. thanks members

@natezzz
Copy link
Contributor

natezzz commented Dec 2, 2015

Yeah this thing is quite confusing for me too.

@takuti
Copy link
Contributor

takuti commented Dec 2, 2015

👍

@harihitode
Copy link
Contributor Author

I was wrong. This is the correct script, however, the phone.scpt is not able to be opened in a common way (like cat or less). You can see this file in the script editor.

open phone.scpt

and I will call this script in unity like this way.

osascript -l JavaScript phone.scpt

@ganmacs
Copy link
Contributor

ganmacs commented Dec 3, 2015

Because we can see the file diff in github web page, I think that changing file name ( phone.scpt -> phone.js ) is better.

if you change file name, you can call this script same way. Maybe 🎅

$ osascript -l JavaScript phone.js

@harihitode
Copy link
Contributor Author

Ok. gamma-san, I agree with your mention. I'll do it.

harihitode pushed a commit that referenced this pull request Dec 12, 2015
harihitode pushed a commit that referenced this pull request Dec 12, 2015
@takuti
Copy link
Contributor

takuti commented Dec 13, 2015

Hi @Sushisushi-sandesu/all,

According to @harihitode, he has successfully created Oculus+LeapMotion Phone app 👏 (and it works on the Oculus screen!) His implementation is based on the widget discussed in /pull/23

This achievement means that he:

@takuti
Copy link
Contributor

takuti commented Dec 13, 2015

@harihitode

Can you give us a more detailed description of your work on here? Please post it w/ some screenshots.

Pushing your code and moving review process can be postponed. Now, sharing your work for us and preparing for the Monday's demo are more important 👍

@ganmacs
Copy link
Contributor

ganmacs commented Dec 13, 2015

Please squash 🙏

ganmacs pushed a commit that referenced this pull request Dec 13, 2015
ganmacs pushed a commit that referenced this pull request Dec 13, 2015
@ganmacs
Copy link
Contributor

ganmacs commented Dec 13, 2015

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants