-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix contrib.gen_coeffs Isat2 temperature dependence #89
BUG: fix contrib.gen_coeffs Isat2 temperature dependence #89
Conversation
* in residual, assume "isat2" in x is at STC, ie "isat2_t0" and calculate isat2 using `diode.isat_t()` * also fix all documentation in gen_coeffs to render okay * make example a callable script, allow user to specify whether they want to fit just STC or all IEC61853, show generated coeffs, and save figure * futurize Bennet's module mismatch simulator for py36 * add contrib, gen_coeffs, and module mismatch simulator to docs in new api section called contrib * add example output figures * fix intersphinx, must use https, leave off trailing slash * don't ignore git conflict files, so they can be removed without hiding * ignore the new .pytest_cache folder, move python3 __pycache__ folder to #build * fix underline in README.rst, should be as long as the title
@chetan201 somehow we missed this 7 months ago, we made the change to PVMismatch to use temperature in Isat2, but not in the coefficient generation I also took this opportunity to add One result of this, is that it highlights the need for PVMismatch to account for irradiance effect on shunt resistance or some other algorithm. |
in RMSE relative to STC
here you can see without Rsh irradiance correction the errors are small near 1 sun, but increase as irradiance decreases: But if I change make ignore the STC RMSE, I need to fix that, forgot to account for NP and NS when I made the first plots, but the seconds set of plots have the update from 257e598 that fixes that the Rsh irradiance dependence is in my |
|
||
def gen_iec_61853_from_sapm(pvmodule): | ||
""" | ||
Generate an IEC 61853 test from Sandia Array Performance Model (sapm). | ||
|
||
:param pvmodule: PV module to be tested | ||
:type pvmodule: dict | ||
:param dict pvmodule: PV module to be tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding docstrings everywhere!
Our future users will thanks us plenty for that :)
@mikofski |
Sorry, I had changed the calculation of the rms error relative to the STC conditions after I made the original plots above, see 257e598 and I've changed them again in 74a0952 to use the actual max power point (
This shows there's more spread in the errors from fits using only STC data vs. the entire IEC61853 data set. I think this error is mostly at Voc, you can see that the curves, don't cross through the IEC measurements. This might be because of #91 or #90 or maybe even because there is still a missing temperature band gap energy dependence #75. I think the power error relative to STC is probably more useful. This is also shown on the plot, and I calculated it like this:
Note, the reason I used STC everywhere in the denominator was so that at very small irradiance, the errors are not exaggerated because the number are so small, eg: the power at 0.1[sun] is 11X less than at 1.1[suns] so should the relative error would have been ( |
@mikofski |
isat2 using
diode.isat_t()
to fit just STC or all IEC61853, show generated coeffs, and save figure
api section called contrib
#build