Support long text #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the text is greater than 5 lines it gets truncated. This switches from using a UILabel to a UITextView. If the text is longer than 5 lines it can now be scrolled, whilst still limiting the size of the alert, and allowing the alert to remain small for short text.
Missed setting UITextView editing off
|
In |
|
This is true. But set it to a high number and you will notice the popup box will grow larger than the bounding window causing the action buttons to disappear off the bottom of the screen. |
|
+1 |
|
can this change request be included in master and next version? |
Conflicts: SIAlertView/SIAlertView.m
if alert being shown when another gets shown, they no longer stack and the last to be shown wins and cleans up the rest
reverse last commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the text is greater than 5 lines it gets truncated.
This switches from using a UILabel to a UITextView. If the text is longer than 5 lines it can now be scrolled, whilst still limiting the size of the alert, and allowing the alert to remain small for short text.