Add support for AES encryption & decryption. #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2020
xqdoo00o
changed the title
|
Hi @Stuk, could you please review this? |
This was referenced Apr 24, 2020
Stuk
requested changes
Apr 25, 2020
There was a problem hiding this comment.
Thanks for the PR!
Would you mind doing the following:
- add some tests and test files added to prove that it works?
- make sure the code formatting follows the existing code (spaces between punctuation etc.). I've added a couple of comments but I see more that needs to follow.
- report on the changes in filesize for
jszip.min.jswith and without gzip compression? If it increases too much we should split this out into an optional add on.
Co-Authored-By: Stuart Knightley <[email protected]>
Co-Authored-By: Stuart Knightley <[email protected]>
|
Hi @Stuk , I tested. |
added 2 commits
April 26, 2020 20:12
Closed
deliangyang
reviewed
May 9, 2020
Co-authored-by: Deliang Yang <[email protected]>
Co-authored-by: Deliang Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just basic code, but surely work for zip aes decryption & encryption. I'm not sure the code flow is enough good, and the 3rd library(sjcl) may need async require(or not, min.js only 20kb bigger).But if the file size large than DEFAULT_BLOCK_SIZE, I think there is a bug , because the data was split.
New efficient code in #696