Immediate-store all of view dialog #3987
Conversation
- also fix smooth fading of rectangular FOV box
- Final NomenclatureMgr fix - Move planet visual magnitude selection logic to SolarSystem property (This also fixes a missing RemoteSync property not syncing) - Update URL for JUPOS
- also move selection of single constellations to starlore and add isolated setting as well. Properties/config keys should be named more fittingly.
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files. |
|
Hello @gzotti! Thank you for the suggested improvement. |
- Config dialog: Info, Extras, Tools - StelMainView
- View dialog - Config dialog - Immediate-store option checkbox to switch modes (Needs one last "save settings action)
- also delete defunct button
|
OK for the SC panel. For the other, it has become a bit convoluted over the last years, historically grown. I understand the top-left options (IIRC the same since ~2010) were options most likely used in an actual planetarium setup (hence the group title): Distortion, disc viewport, gravity labels. For explanations in a planetarium (and actually also regular screens), the "select single constellations" was there as well, but it better fits to the SC panel. The Auto-zoom-out (yes, still open issue...) is also an option apparently (I never used it, so missed its relevance, sorry) invented for and most critically used in a planetarium. The rest of the tab looks like a collection of "I didn't know where to place it, so I added it here". Decimal degrees and Az. from south could both move to the Extras/Info details tab. (Just have two columns in the top area.) Another thing is the font selection which is still hidden by default and needs a manual edit to config.ini. Shall we show it to all at beginners level? |
Both options touching not only information section, but yes, them can be moved to the Extras/Info tab.
Well, View/Sky and View/SSO are bloated already, but you’re right - these options can be moved there.
Yep.
I fear it may be very painful for beginners… |
Indeed Sky and SSO were already large. I left them in the Config dialog, but moved to Info as well. These 3 options involve position refinements, but also of course the provided information. In light of current work on the star catalog, topocentric flag could also switch parallax observance for stars, or this will need another flag later. I edited the .ui XML directly to also clean up the meanwhile 18 (or so) rows in the Info dialog layout. Maybe the currently only used colums 1 and 3 should also be edited back to 0 and 1? The mag/squareArcMin and "use symbol" settings are AFAICS used only for DSO. Might be moved there, but the current shortened strings are also OK. (Can they be combined into 1 line?)
OK, I left the default-hidden font panel as it was. |
|
This is OK:
This is not OK: Topocentric coordinates, nutation and aberration touches not only information box - they touches rendering the sky, so, Extras/Info is bad place for all of them. It may be accepatble for moving to View/SSO tab, but definitely to to Extras/Info. Topocentric coordinates, nutation and aberration should be moved back to Tools tab, IMHO.
The current view for these lines are OK for me. |
|
OK, next try. |
alex-w
added
the
state: published
|
Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @gzotti! Please check the latest stable version of Stellarium: |
Description
This continues a series of changes which aims at optionally avoiding the requirement to press "save settings".
All features in the View settings dialog and Configuration should be immediate-store now.
The Language and font settings are probably the only settings that crucially needs to be protected by an explicit store so they are not messed up on a panic exit. All other settings are as easy to reset as they were set.
In the end of this branch, the "save settings" button will be disabled when the corresponding "immediate storage" option in the config dialog has been activated.
It is to be discussed whether "save languages" and "save fonts" buttons should only be available in this new mode. Else they would cause no harm.
Plugins usually have their own "save settings" logic. They may be modified later.
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: