Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix a bug that when catalog is unified catalog the background refresh for hive connector do not work #55215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duanyyyyyyy
Copy link
Contributor

Fix a bug that when catalog is unified catalog the background refresh for hive connector do not work

Why I'm doing:

We found that when we use unified catalog the background refresh will not work.
Because that when we register into the map, we will use the same key.

What I'm doing:

Introduce a new object named ConnectorProcessorName and use this object as the key.
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

…for hive connector do not work

Signed-off-by: duanyyyyyyy <[email protected]>
@duanyyyyyyy duanyyyyyyy force-pushed the background_refresh_bug_fix branch from b5f5f94 to 55b0ee0 Compare January 17, 2025 16:03
Copy link

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 22 / 26 (84.62%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/hive/ConnectorTableMetadataProcessor.java 9 12 75.00% [107, 108, 109]
🔵 com/starrocks/connector/hive/ConnectorProcessorName.java 5 6 83.33% [28]
🔵 com/starrocks/connector/delta/DeltaLakeConnector.java 3 3 100.00% []
🔵 com/starrocks/connector/hive/HiveConnector.java 3 3 100.00% []
🔵 com/starrocks/connector/hudi/HudiConnector.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant