Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix using incorrect read ratio when sampling to collect table statistics #55198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Jan 17, 2025

Why I'm doing:

currently we use tablet sample ratio as tablet read ratio. it should be mistake.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@stephen-shelby stephen-shelby requested a review from a team as a code owner January 17, 2025 06:21
murphyatwork
murphyatwork previously approved these changes Jan 17, 2025
Seaven
Seaven previously approved these changes Jan 17, 2025
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby dismissed stale reviews from Seaven and murphyatwork via 6bc7591 January 17, 2025 08:50
@stephen-shelby stephen-shelby force-pushed the fix_error_tablet_read_ratio branch from e394a1b to 6bc7591 Compare January 17, 2025 08:50
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants