Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] PageIndexReader support use MinMaxPredicate to filter page with column stats (backport #54005) #55155

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 16, 2025

Why I'm doing:

What I'm doing:

PageIndexReader use MinMaxPredicate (which is generated by runtime filter) to filter page with column stats

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Jan 16, 2025
Copy link
Contributor Author

mergify bot commented Jan 16, 2025

Cherry-pick of a703026 has failed:

On branch mergify/bp/branch-3.3/pr-54005
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit a7030265ee.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/exprs/min_max_predicate.h
	modified:   be/src/formats/parquet/file_reader.cpp
	modified:   be/src/formats/parquet/file_reader.h
	modified:   be/src/formats/parquet/group_reader.h
	modified:   be/src/formats/parquet/statistics_helper.cpp
	modified:   be/src/formats/parquet/statistics_helper.h
	modified:   be/test/formats/parquet/statistics_helper_test.cpp
	new file:   be/test/formats/parquet/test_data/filter_page_index_with_rf_has_null.parquet

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/formats/parquet/page_index_reader.cpp
	both modified:   be/src/runtime/types.h
	both modified:   be/test/formats/parquet/file_reader_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 16, 2025 10:39
@mergify mergify bot closed this Jan 16, 2025
auto-merge was automatically disabled January 16, 2025 10:39

Pull request was closed

Copy link
Contributor Author

mergify bot commented Jan 16, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@trueeyu trueeyu reopened this Jan 16, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 16, 2025 10:42
@trueeyu trueeyu force-pushed the mergify/bp/branch-3.3/pr-54005 branch from 5a4eefd to 5e2ef3e Compare January 16, 2025 10:42
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
@wanpengfei-git wanpengfei-git merged commit 511a930 into branch-3.3 Jan 17, 2025
26 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-54005 branch January 17, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants