Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Rename OlapRuntimeScanRangePruner to RuntimeScanRangePruner #55154

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Jan 16, 2025

Why I'm doing:

OlapRuntimeScanRangePruner is also used by external table, so rename to RuntimeScanRangePruner.

What I'm doing:

Rename OlapRuntimeScanRangePruner to RuntimeScanRangePruner

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@trueeyu trueeyu requested review from a team as code owners January 16, 2025 10:23
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 115 / 137 (83.94%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/connector/lake_connector.cpp 0 1 00.00% [263]
🔵 be/src/storage/runtime_range_pruner.hpp 99 120 82.50% [43, 44, 60, 61, 73, 74, 136, 137, 138, 139, 140, 143, 144, 146, 160, 164, 171, 172, 182, 183, 229]
🔵 be/src/formats/parquet/file_reader.cpp 1 1 100.00% []
🔵 be/src/exec/pipeline/scan/olap_chunk_source.cpp 1 1 100.00% []
🔵 be/src/exec/hdfs_scanner.cpp 1 1 100.00% []
🔵 be/src/storage/runtime_range_pruner.h 13 13 100.00% []

@wyb wyb merged commit e3f5de0 into StarRocks:main Jan 17, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants