Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Use cluster_snapshot_path to specify the cluster snapshot to be restored #55147

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[Enhancement] Use cluster_snapshot_path to specify the cluster snapshot to be restored #55147

merged 1 commit into from
Jan 17, 2025
+22 −42

Conversation

xiangguangyxg
Copy link
Contributor

@xiangguangyxg xiangguangyxg commented Jan 16, 2025 •
edited
Loading

Why I'm doing:

Previously, using cluster_service_id and cluster_snapshot_name to specify the cluster snapshot to be restored is not user-friendly.

What I'm doing:

Use cluster_snapshot_path to specify the cluster snapshot to be restored.

Fixes #53867

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@github-actions github-actions bot added the 3.4 label Jan 16, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 6 / 8 (75.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/lake/snapshot/RestoreClusterSnapshotMgr.java 3 5 60.00% [121, 127]
🔵 com/starrocks/lake/snapshot/ClusterSnapshotConfig.java 3 3 100.00% []

@andyziye andyziye merged commit 6e86e45 into StarRocks:main Jan 17, 2025
60 of 61 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 17, 2025
@xiangguangyxg @mergify
[Enhancement] Use cluster_snapshot_path to specify the cluster snapsh…
3c111ab 
…ot to be restored (#55147)

Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 6e86e45)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/lake/snapshot/RestoreClusterSnapshotMgrTest.java
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
18 tasks
@xiangguangyxg xiangguangyxg deleted the cluster_snapshot_path branch January 17, 2025 03:04
wanpengfei-git pushed a commit that referenced this pull request Jan 17, 2025
@mergify @xiangguangyxg
[Enhancement] Use cluster_snapshot_path to specify the cluster snapsh…
396f81c 
…ot to be restored (backport #55147) (#55181)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srlch srlch srlch approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@xiangguangyxg xiangguangyxg

Labels
3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shared-data mode support backup restore though automated snapshot
5 participants
@xiangguangyxg @kevincai @gengjun-git @srlch @andyziye