[BugFix] RangePredicateExtractor discard predicates mistakenly #50854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiShuMing
reviewed
Sep 9, 2024
| @@ -57,6 +57,7 @@ private ScalarOperator rewrite(ScalarOperator predicate, boolean onlyExtractColu | |||
|
|
|||
| Set<ScalarOperator> conjuncts = Sets.newLinkedHashSet(); | |||
| conjuncts.addAll(Utils.extractConjuncts(predicate)); | |||
| predicate = Utils.compoundAnd(conjuncts); | |||
There was a problem hiding this comment.
Why do this? only to clone it?
There was a problem hiding this comment.
Eliminate duplicates of predicates.
Signed-off-by: satanson <[email protected]>
satanson
force-pushed
the
discard_predicates
branch
from
5b62259 to
f73e7bd
Compare
|
LiShuMing
approved these changes
Sep 9, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
packy92
approved these changes
Sep 10, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
|
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: satanson <[email protected]> (cherry picked from commit cffaa19) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarRangePredicateExtractor.java # fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorRewriterTest.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/PruneUKFKJoinRuleTest.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/SubqueryTest.java
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: satanson <[email protected]> (cherry picked from commit cffaa19) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarRangePredicateExtractor.java # fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorRewriterTest.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/PruneUKFKJoinRuleTest.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/SubqueryTest.java
This was referenced Sep 10, 2024
satanson
added a commit
that referenced
this pull request
Sep 10, 2024
…ort #50854) Signed-off-by: satanson <[email protected]>
42 tasks
satanson
added a commit
that referenced
this pull request
Sep 10, 2024
…ort #50854) Signed-off-by: satanson <[email protected]>
42 tasks
satanson
added a commit
that referenced
this pull request
Sep 10, 2024
…ort #50854) Signed-off-by: satanson <[email protected]>
42 tasks
satanson
added a commit
that referenced
this pull request
Sep 10, 2024
…ort #50854) Signed-off-by: satanson <[email protected]>
42 tasks
satanson
added a commit
that referenced
this pull request
Sep 10, 2024
…ort #50854) Signed-off-by: satanson <[email protected]>
satanson
added a commit
that referenced
this pull request
Sep 10, 2024
…ort #50854) Signed-off-by: satanson <[email protected]>
42 tasks
andyziye
pushed a commit
that referenced
this pull request
Sep 10, 2024
…ort #50854) (#50886) Signed-off-by: satanson <[email protected]>
satanson
added a commit
that referenced
this pull request
Sep 10, 2024
…ort #50854) Signed-off-by: satanson <[email protected]>
42 tasks
HangyuanLiu
pushed a commit
to HangyuanLiu/starrocks
that referenced
this pull request
Sep 12, 2024
…ocks#50854) Signed-off-by: satanson <[email protected]>
satanson
added a commit
that referenced
this pull request
Sep 19, 2024
…ort #50854) Signed-off-by: satanson <[email protected]>
satanson
added a commit
that referenced
this pull request
Sep 19, 2024
…ort #50854) (#50887) Signed-off-by: satanson <[email protected]>
ZiheLiu
pushed a commit
that referenced
this pull request
Sep 19, 2024
…ort #50854) (#50896) Signed-off-by: satanson <[email protected]>
ZiheLiu
pushed a commit
that referenced
this pull request
Sep 19, 2024
…ort #50854) (#50898) Signed-off-by: satanson <[email protected]>
ZiheLiu
pushed a commit
that referenced
this pull request
Sep 19, 2024
…ort #50854) (#50906) Signed-off-by: satanson <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…ocks#50854) Signed-off-by: satanson <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Fix bug: #50311
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: