[BugFix] Add more check and info when compaction find row size inconsistency (backport #33972) #34051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
…istency (#33972) Add more debug&verify log to address #33971 Signed-off-by: Binglin Chang <[email protected]> (cherry picked from commit 5322894)
decster
force-pushed
the
mergify/bp/branch-2.5/pr-33972
branch
5 times, most recently
from
a0390ac to
b519868
Compare
Fixes #25337 Recently, we encountered some data corruption bugs after compaction/schema-change, especially for the sort key enabled table. It's better to add a function to check compaction/schema-change correctness, so as to notice bugs earlier. This PR adds a function to check rowset correctness(currently checks each segment file's key/order key is ordered, and unique if it's pk table and data is ordered by pk). There are 2 ways to invoke/enable rowset verify 1. BE config `enable_rowset_verify`, if enabled, compaction and schema_change creating a new rowset will do a verification after rowset is generated. 2. bind `Tablet::verify` method to script engine, so user can verify each tablet manually, or verify all the tablets of a table in a loop using script. (cherry picked from commit dba492c) Signed-off-by: Binglin Chang <[email protected]>
decster
force-pushed
the
mergify/bp/branch-2.5/pr-33972
branch
from
b519868 to
908cfc3
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 124 / 149 (83.22%) file detail
|
decster
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #33972 done by Mergify.
Cherry-pick of 5322894 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com