Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix mod operator not be parsed correctly #33073

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[BugFix] fix mod operator not be parsed correctly #33073

merged 1 commit into from
Oct 18, 2023

Conversation

packy92
Copy link
Contributor

@packy92 packy92 commented Oct 18, 2023 •
edited
Loading

Fixes #issue
select 100 mod 2 doesn't be parsed correctly.
image

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
0.1% 0.1% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@imay imay merged commit 33e1c8b into StarRocks:main Oct 18, 2023
68 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 18, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 18, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Oct 18, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Oct 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@packy92 @mergify
[BugFix] fix mod operator not be parsed correctly (#33073)
baa4930 
select 100 mod 2 doesn't be parsed correctly.

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 33e1c8b)
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@packy92 @mergify
[BugFix] fix mod operator not be parsed correctly (#33073)
6703477 
select 100 mod 2 doesn't be parsed correctly.

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 33e1c8b)
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@packy92 @mergify
[BugFix] fix mod operator not be parsed correctly (#33073)
93648dc 
select 100 mod 2 doesn't be parsed correctly.

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 33e1c8b)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/parser/ParserTest.java
This was referenced Oct 18, 2023
Merged
Merged
@mergify mergify bot mentioned this pull request Oct 18, 2023
Closed
mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@packy92 @mergify
[BugFix] fix mod operator not be parsed correctly (#33073)
1babdd4 
select 100 mod 2 doesn't be parsed correctly.

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 33e1c8b)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/parser/ParserTest.java
@mergify mergify bot mentioned this pull request Oct 18, 2023
Closed
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2023
@packy92 @wanpengfei-git
[BugFix] fix mod operator not be parsed correctly (#33073)
9c16797 
select 100 mod 2 doesn't be parsed correctly.

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 33e1c8b)
packy92 added a commit that referenced this pull request Oct 19, 2023
@packy92
[BugFix] fix mod operator not be parsed correctly (#33073)
53c92aa 
Signed-off-by: packy <[email protected]>
packy92 added a commit to packy92/starrocks that referenced this pull request Oct 20, 2023
@packy92
[BugFix] fix mod operator not be parsed correctly (backport StarRocks…
b1b03c7 
…#33073)

Signed-off-by: packy92 <[email protected]>
satanson pushed a commit that referenced this pull request Oct 20, 2023
@packy92
[BugFix] fix mod operator not be parsed correctly (backport #33073) (#…
9180b44 
…33232)

Signed-off-by: packy92 <[email protected]>
packy92 added a commit to packy92/starrocks that referenced this pull request Oct 20, 2023
@packy92
[BugFix] fix mod operator not be parsed correctly (backport StarRocks…
b5dfb43 
…#33073)

Signed-off-by: packy92 <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 20, 2023
@packy92 @wanpengfei-git
[BugFix] fix mod operator not be parsed correctly (backport #33073)
bd7ef06 
Signed-off-by: packy92 <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 20, 2023
@packy92 @wanpengfei-git
[BugFix] fix mod operator not be parsed correctly (#33073)
4e22bf1 
select 100 mod 2 doesn't be parsed correctly.

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 33e1c8b)
wanpengfei-git pushed a commit that referenced this pull request Oct 20, 2023
@packy92 @wanpengfei-git
[BugFix] fix mod operator not be parsed correctly (#33073)
f52aee7 
Signed-off-by: packy <[email protected]>
murphyatwork pushed a commit to murphyatwork/starrocks that referenced this pull request Oct 23, 2023
@packy92 @murphyatwork
[BugFix] fix mod operator not be parsed correctly (StarRocks#33073)
af987a5 
select 100 mod 2 doesn't be parsed correctly.

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 33e1c8b)
murphyatwork pushed a commit to murphyatwork/starrocks that referenced this pull request Oct 23, 2023
@packy92 @murphyatwork
[BugFix] fix mod operator not be parsed correctly (StarRocks#33073)
94bc660 
Signed-off-by: packy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@imay imay imay approved these changes

Assignees

@packy92 packy92

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@packy92 @wanpengfei-git @imay @Seaven @jaogoy