[Tool] Support ddprof integration #32758
Open
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Deng Liu <[email protected]>
[FE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
dengliu
changed the title
[BE Incremental Coverage Report]😍 pass : 0 / 0 (0%) |
kevincai
reviewed
Oct 14, 2023
| @@ -51,4 +51,10 @@ COPY --from=fe-builder /build/starrocks/output /release/fe_artifacts | |||
| COPY --from=be-builder /build/starrocks/output /release/be_artifacts | |||
| COPY --from=broker-builder /build/starrocks/fs_brokers/apache_hdfs_broker/output /release/broker_artifacts | |||
|
|
|||
|
|
|||
| # Get ddprof | |||
| RUN wget https://github.com/DataDog/ddprof/releases/download/v0.14.1/ddprof-0.14.1-amd64-linux.tar.xz -O ddprof-amd64-linux.tar.xz && \ | |||
There was a problem hiding this comment.
this won't work for arm platform. consider move to thirdparty so it will be available in non-container env?
There was a problem hiding this comment.
can you give me an example how to add it to thirdparty?
Thank you!
kevincai
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
With this PR, the starrocks be can be started with ddprof with this env variable
ENABLE_DD_PROFILE = trueDoes this PR entail a change in behavior?
Checklist:
I have tested the correctness of integration test with Datadog
Bugfix cherry-pick branch check: