Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
Signed-off-by: sevev <[email protected]>
  • Loading branch information
sevev committed Jan 16, 2025
1 parent 851149e commit 8578edc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
1 change: 0 additions & 1 deletion be/src/common/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -1538,5 +1538,4 @@ CONF_mInt32(json_parse_many_batch_size, "1000000");
CONF_mBool(enable_dynamic_batch_size_for_json_parse_many, "true");
CONF_mInt32(put_combined_txn_log_thread_pool_num_max, "64");
CONF_mBool(enable_put_combinded_txn_log_parallel, "false");
CONF_mBool(output_combined_txn_log, "false");
} // namespace starrocks::config
9 changes: 1 addition & 8 deletions be/src/exec/tablet_sink_sender.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -372,20 +372,13 @@ bool TabletSinkSender::get_immutable_partition_ids(std::set<int64_t>* partition_
Status TabletSinkSender::_write_combined_txn_log() {
int64_t t_start = MonotonicMillis();
if (config::enable_put_combinded_txn_log_parallel) {
Status st = write_combined_txn_log(_txn_log_map);
if (config::output_combined_txn_log) {
LOG(INFO) << "write_combined_txn_log parallel cost time: " << MonotonicMillis() - t_start;
}
return st;
return write_combined_txn_log(_txn_log_map);
}

for (const auto& [partition_id, logs] : _txn_log_map) {
(void)partition_id;
RETURN_IF_ERROR(write_combined_txn_log(logs));
}
if (config::output_combined_txn_log) {
LOG(INFO) << "write_combined_txn_log non-parallel cost time: " << MonotonicMillis() - t_start;
}
return Status::OK();
}

Expand Down
1 change: 1 addition & 0 deletions be/src/runtime/exec_env.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,7 @@ void ExecEnv::destroy() {
SAFE_DELETE(_lake_update_manager);
SAFE_DELETE(_lake_replication_txn_manager);
SAFE_DELETE(_cache_mgr);
SAFE_DELETE(_put_combined_txn_log_thread_pool);
_dictionary_cache_pool.reset();
_automatic_partition_pool.reset();
_metrics = nullptr;
Expand Down

0 comments on commit 8578edc

Please sign in to comment.