-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ENGAGE-HF Allergy Form #3
base: main
Are you sure you want to change the base?
Conversation
…add ObservationForm, add PatientForm
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks a lot for adding some health components! 🚀
Especially, I think it makes a lot of sense to extend the test cases for some components and maybe also add storybook stories so it is easier to inspect the different components and decide whether it is useful for their project, but this would be for separate PRs.
I'll take a look at this soon, hopefully tomorrow. |
Co-authored-by: ThomasKaar <[email protected]>
…endencies, ignore config files in codecov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on that! I left my points. Some of them are nits, some can be addressed in separate PRs. Please, create issues if handled as separate.
Some comments might require to be handled PR-wise. I didn't create a comment for every instance where issue exists, like Array.at
thing.
I didn't finish my review, but that's what I have so far. Please let me know if any questions.
Co-authored-by: Arkadiusz Bachorski <[email protected]>
Co-authored-by: Arkadiusz Bachorski <[email protected]>
Co-authored-by: Arkadiusz Bachorski <[email protected]>
@arkadiuszbachorski Thanks for the detailed feedback, extremely helpful! Excited to get this merged soon 🚀 |
# Updates to Allergy From This mostly concludes missing elements from my feedback. There are also other missing elements, but I'll create separate issues/PRs for that. I just want to merge what is already there, to simplify the process. Feel free to ask if anything is not clear enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged my PR, let's ship this 🚀
Add ENGAGE-HF Allergy Form, Observation Form & PatientForm
⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: