Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENGAGE-HF Allergy Form #3

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Conversation

NikolaiMadlener
Copy link
Collaborator

@NikolaiMadlener NikolaiMadlener commented Oct 23, 2024

Add ENGAGE-HF Allergy Form, Observation Form & PatientForm

⚙️ Release Notes

  • Add AllergyForm from ENGAGE-HF and supporting MedicationSelect component
  • Replace custom models used in ENGAGE AllergyForm with medplum FHIR types.
  • Add ObservationForm from ENGAGE-HF
  • Add PatientsTable component
  • Update GitHub actions to configure publishing a package
  • Remove old Next-related dependencies, files, configurations

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@NikolaiMadlener NikolaiMadlener changed the title Feat/allergy form Add ENGAGE-HF Allergy Form Oct 23, 2024
@NikolaiMadlener NikolaiMadlener self-assigned this Nov 4, 2024
@NikolaiMadlener NikolaiMadlener added the enhancement New feature or request label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Collaborator

@ThomasKaar ThomasKaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot for adding some health components! 🚀

Especially, I think it makes a lot of sense to extend the test cases for some components and maybe also add storybook stories so it is easier to inspect the different components and decide whether it is useful for their project, but this would be for separate PRs.

postcss.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/AllergyForm/AllergyForm.tsx Show resolved Hide resolved
src/components/AllergyForm/MedicationSelect.tsx Outdated Show resolved Hide resolved
src/modules/fhir/allergy-intolerance.ts Outdated Show resolved Hide resolved
@arkadiuszbachorski
Copy link
Collaborator

I'll take a look at this soon, hopefully tomorrow.

Copy link
Collaborator

@arkadiuszbachorski arkadiuszbachorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on that! I left my points. Some of them are nits, some can be addressed in separate PRs. Please, create issues if handled as separate.

Some comments might require to be handled PR-wise. I didn't create a comment for every instance where issue exists, like Array.at thing.

I didn't finish my review, but that's what I have so far. Please let me know if any questions.

.github/workflows/deployment.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/AllergyForm/AllergyForm.test.tsx Outdated Show resolved Hide resolved
src/components/PatientsTable/PatientsTable.test.tsx Outdated Show resolved Hide resolved
src/components/PatientsTable/PatientMenu.tsx Outdated Show resolved Hide resolved
src/components/PatientForm/PatientForm.tsx Show resolved Hide resolved
@NikolaiMadlener
Copy link
Collaborator Author

@arkadiuszbachorski Thanks for the detailed feedback, extremely helpful!
Most of the points should be resolved now (with some being moved into new Github issues).
Feel free to resolve the discussions above if the adjustments look good to you.

Excited to get this merged soon 🚀

.github/workflows/deployment.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/AllergyForm/AllergyForm.tsx Outdated Show resolved Hide resolved
# Updates to Allergy From

This mostly concludes missing elements from my feedback. There are also
other missing elements, but I'll create separate issues/PRs for that. I
just want to merge what is already there, to simplify the process.

Feel free to ask if anything is not clear enough.
Copy link
Collaborator

@arkadiuszbachorski arkadiuszbachorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged my PR, let's ship this 🚀

@NikolaiMadlener NikolaiMadlener enabled auto-merge (squash) January 15, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants