-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documentation in Conformance to the Documentation Guide #36
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 66.49% 66.49%
=======================================
Files 10 10
Lines 549 549
=======================================
Hits 365 365
Misses 184 184 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starring with improving the documentation here @vishnuravi; this is greatly appreciated 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements @vishnuravi!
I fixed some configuration issues with the swift package index that I wanted to fix at some point anyways and also renamed a few of the image files to follow the ~dark
prefix instead of -dark
and to ensure that the dark and light mode images are named the same.
Feel free to merge the PR, it would be great to see if we can ensure that the images in the main README table are the same size as noted in the comment 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, this looks really good and thank you for fixing the scaling issue here 🚀
Update Documentation in Conformance to the Documentation Guide
♻️ Current situation & Problem
See issue #24.
⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: