Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation in Conformance to the Documentation Guide #36

Merged
merged 12 commits into from
Nov 1, 2023

Conversation

vishnuravi
Copy link
Member

Update Documentation in Conformance to the Documentation Guide

♻️ Current situation & Problem

See issue #24.

⚙️ Release Notes

  • Updated documentation with setup instructions and examples.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #36 (6ba9a36) into main (63cb665) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   66.49%   66.49%           
=======================================
  Files          10       10           
  Lines         549      549           
=======================================
  Hits          365      365           
  Misses        184      184           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63cb665...6ba9a36. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starring with improving the documentation here @vishnuravi; this is greatly appreciated 🚀

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@vishnuravi vishnuravi marked this pull request as ready for review November 1, 2023 03:56
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements @vishnuravi!

I fixed some configuration issues with the swift package index that I wanted to fix at some point anyways and also renamed a few of the image files to follow the ~dark prefix instead of -dark and to ensure that the dark and light mode images are named the same.

Feel free to merge the PR, it would be great to see if we can ensure that the images in the main README table are the same size as noted in the comment 👍

README.md Outdated Show resolved Hide resolved
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, this looks really good and thank you for fixing the scaling issue here 🚀

@vishnuravi vishnuravi merged commit 769ad38 into main Nov 1, 2023
8 checks passed
@vishnuravi vishnuravi deleted the documentation branch November 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants