Properly mark ModuleOwnership as Sendable

[Supereg]

Properly mark ModuleOwnership as Sendable

♻️ Current situation & Problem

This PR adds a missing and forgotten Sendable conformance.

⚙️ Release Notes

• Sendable and Hashable conformance for ModuleOwnership.

📚 Documentation

✅ Testing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[Supereg]

@PSchmiedmayer we have some XCTRuntimePreconditions that are impossible to test anymore with property data isolation (e.g., checking that a constraint is satisfied). With the recent change to XCTRuntimeAssertions (StanfordBDHG/XCTRuntimeAssertions#14), the closures passed to XCTRuntimePrecondition are now properly annotated as @Sendable closures. This makes it impossible to run XCTRuntimePreconditions with symbols that need to be isolated to the @MainActor. Either the closure will only run after the call to XCTRuntimePreconditions completed (if the call is made from the MainActor) or the MainActor will be blocked forever as the injected precondition(...) call loops forever.

Potential ways out:

• Remove the @Sendable annotation from XCTRuntimePrecondition calls and just silently break concurrence guarantees.
• Don't test preconditions anymore that are isolated to the MainActor.

What do you think is a sensible way going forward?

[PSchmiedmayer]

@Supereg As discussed on Slack I would aim for a testing-specific but documented slightly unsafe behavior in XCTRuntimePrecondition to ensure that we can at least validate some assertions/preconditions within our codebases.

[PSchmiedmayer]

Happy to see this merged once we addressed the current testing issues 🚀

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.85%. Comparing base (fffb691) to head (d7ad126).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files          45       45           
  Lines        1392     1392           
=======================================
  Hits         1195     1195           
  Misses        197      197           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fffb691...d7ad126. Read the comment docs.