Skip to content
Pull Request

Restructure @Dependency property and use BFS for DependencyManager #601

Sign in to view logs

Restructure @Dependency property and use BFS for DependencyManager

Restructure @Dependency property and use BFS for DependencyManager #601

Triggered via pull request July 31, 2024 14:35
@SuperegSupereg
opened #112
feature/dependency-restructure
Status Failure
Total duration 54s
Artifacts –

pull_request.yml

on: pull_request
REUSE Compliance Check  /  ...  /  REUSE Compliance Check
15s
REUSE Compliance Check / REUSE Compliance Check / REUSE Compliance Check
SwiftLint  /  ...  /  SwiftLint
22s
SwiftLint / SwiftLint / SwiftLint
Markdown Link Check  /  markdown_link_check
42s
Markdown Link Check / markdown_link_check
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/Property/DependencyBuilder.swift#L15
Todo Violation: TODOs should be resolved (review how to treat those here...) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/Property/DependencyCollection.swift#L43
Todo Violation: TODOs should be resolved (update these?) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/Property/DependencyPropertyWrapper.swift#L86
Function Default Parameter at End Violation: Prefer to locate parameters with defaults toward the end of the parameter list (function_default_parameter_at_end)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/Property/DependencyPropertyWrapper.swift#L74
Missing Docs Violation: public declarations should be documented (missing_docs)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/Property/DependencyPropertyWrapper.swift#L86
Missing Docs Violation: public declarations should be documented (missing_docs)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/Property/DependencyPropertyWrapper.swift#L70
Todo Violation: TODOs should be resolved (default value might depend on ...) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/Property/DependencyPropertyWrapper.swift#L87
Todo Violation: TODOs should be resolved (allow to loadModule within the...) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/Property/DependencyPropertyWrapper.swift#L92
Todo Violation: TODOs should be resolved (deprecate?, manually specify d...) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/DependencyManager.swift#L125
Function Default Parameter at End Violation: Prefer to locate parameters with defaults toward the end of the parameter list (function_default_parameter_at_end)
SwiftLint / SwiftLint / SwiftLint: Sources/Spezi/Dependencies/DependencyManager.swift#L105
Todo Violation: TODOs should be resolved (postpone that? we might have a...) (todo)
Markdown Link Check / markdown_link_check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/