forked from ResearchKit/ResearchKit
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync SwiftUI branch #32
Closed
Closed
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6cfb995
cleaning up unused strings (#1578)
louie-apple 57427e8
Set “Enable Module Verifier” flag to “Yes” only in Release build conf…
aplummer-apple b274d1f
Update README.md
Pariecemckinney-apple 5c5d295
Public release 3.1.0
Pariecemckinney-apple eedd39d
Public beta release - SwiftUI
simon-apple 78b345a
merge upstream SwiftUI branch and resolve conflicts
NikolaiMadlener 4e5d0c0
Update iPhone Used for Testing
PSchmiedmayer dbee8f0
Excape String
PSchmiedmayer 0fc1e5e
Update Setup
PSchmiedmayer 003a2d8
change SwiftUI target
NikolaiMadlener 9195803
Merge branch 'SwiftUI' of github.com:StanfordBDHG/ResearchKit into Sw…
NikolaiMadlener 50d3f85
dependencies must precede path
NikolaiMadlener 2230d3a
add default localization
NikolaiMadlener d070ebd
lift iOS version to v18
NikolaiMadlener 1f294e6
lift swift-tools version to 6.0
NikolaiMadlener 25bedec
back to iOS 17
NikolaiMadlener 5e6acad
iOS18
NikolaiMadlener 996fb44
concurrency safety
NikolaiMadlener ca47c25
concurrency safety
NikolaiMadlener c21ab46
remove dependencies from swiftui target
NikolaiMadlener 05b21be
add RK dependency to RKSwiftUI target
NikolaiMadlener ee57914
add swift testing dependency
NikolaiMadlener 0550213
adjust swift testing version
NikolaiMadlener e42f48f
Remove Testig
PSchmiedmayer 4a50b01
exlude RKSwiftUI from SwiftLint
NikolaiMadlener 771a074
move back to old SwiftUI target in package.siwft
NikolaiMadlener afd5abe
remove RKSwiftUI target
NikolaiMadlener 37f7668
remove StrictConcurrency from package.swift
NikolaiMadlener File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
Pod::Spec.new do |s| | ||
s.name = 'ResearchKit' | ||
s.version = '3.0.1' | ||
s.summary = 'ResearchKit is an open source software framework that makes it easy to create apps for medical research or for other research projects.' | ||
s.homepage = 'https://www.github.com/ResearchKit/ResearchKit' | ||
s.documentation_url = 'http://researchkit.github.io/docs/' | ||
s.license = { :type => 'BSD', :file => 'LICENSE' } | ||
s.author = { 'researchkit.org' => 'http://researchkit.org' } | ||
s.source = { :git => 'https://github.com/ResearchKit/ResearchKit.git', :tag => s.version.to_s } | ||
|
||
s.default_subspec = "ResearchKitAllTargets" | ||
|
||
s.subspec 'ResearchKitCore' do |ss| | ||
ss.vendored_frameworks = 'xcframework/ResearchKit.xcframework' | ||
end | ||
|
||
s.subspec 'ResearchKitUI' do |ss| | ||
ss.vendored_frameworks = 'xcframework/ResearchKitUI.xcframework' | ||
ss.dependency 'ResearchKit/ResearchKitCore' | ||
end | ||
|
||
s.subspec 'ResearchKitActiveTask' do |ss| | ||
ss.vendored_frameworks = 'xcframework/ResearchKitActiveTask.xcframework' | ||
ss.dependency 'ResearchKit/ResearchKitUI' | ||
ss.dependency 'ResearchKit/ResearchKitCore' | ||
end | ||
|
||
s.subspec 'ResearchKitAllTargets' do |ss| | ||
ss.dependency 'ResearchKit/ResearchKitCore' | ||
ss.dependency 'ResearchKit/ResearchKitUI' | ||
ss.dependency 'ResearchKit/ResearchKitActiveTask' | ||
end | ||
end | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will have to keep our old ResearchKitSwiftUI target in place while adding a new one pointing to the one created by Apple as a new target. As we will have to tag a major version anyways (moving to only iOS 18 is a breaking change), we might want to:
ResearchKitSwitUIBridge
or something and add the new Apple target asResearchKitSwiftUI
. While Apple might take a long time to finish up their implementation we could tag4.0.0-beta.1
or similar releases on that branch including the breaking iOS 18 requirement. Eventually it would be great if Apple would do so but until then we have to maintain this ourselves ...