Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Strict Concurrency #30

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 11, 2024

Support Strict Concurrency

♻️ Current situation & Problem

This PR enables strict concurrency for the ResearchKitSwiftUI targets. Swift 6 is now fully supported.

⚙️ Release Notes

  • Compatibility with Swift 6

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer August 11, 2024 11:41
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you @Supereg!

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Aug 14, 2024
@Supereg
Copy link
Member Author

Supereg commented Aug 29, 2024

Just saw that this PR isn't merged yet. Could you force merge this PR @PSchmiedmayer? I currently do not have the permission for that. Codecov sadly wasn't able to provide codecov results after two attempts.

@Supereg
Copy link
Member Author

Supereg commented Aug 29, 2024

It seems like the main branch never collected any coverage reports? Also the last few PRs also didn't collect any coverage. Maybe it is a configuration issue?

@Supereg
Copy link
Member Author

Supereg commented Aug 29, 2024

@PSchmiedmayer I updated the build_and_test action to also run on a push to main. This should ensure code coverage will work in the future.

@PSchmiedmayer PSchmiedmayer merged commit bb32d10 into main Aug 29, 2024
18 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/strict-concurrency branch August 29, 2024 15:15
@PSchmiedmayer
Copy link
Member

Sure; thanks for the reminder! I just merged the PR 👍

@Supereg
Copy link
Member Author

Supereg commented Aug 29, 2024

thank you 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants