Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes data race in LocationModule #52

Merged
merged 4 commits into from
Dec 28, 2024
Merged

Fixes data race in LocationModule #52

merged 4 commits into from
Dec 28, 2024

Conversation

vishnuravi
Copy link
Member

@vishnuravi vishnuravi commented Dec 28, 2024 •
edited
Loading

Fixes data race in LocationModule

Major changes:

  • This PR fixes a data race caused by multiple threads modifying the location array simultaneously. A crash was reported by a user caused by location data being updated while simultaneously read by the map view.
  • This is done by creating a dedicated LocationStorage actor that manages all access to the location array, and performing all data modifications through the actor's methods.

Minor changes:

  • Adds documentation to functions in the LifeSpaceStandard.
  • Tracks the last successful HealthKit data transmission for debugging purposes.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@vishnuravi vishnuravi marked this pull request as ready for review December 28, 2024 19:25
@vishnuravi vishnuravi merged commit 7f524a9 into main Dec 28, 2024
3 checks passed
@vishnuravi vishnuravi deleted the fix-concurrency branch December 28, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vishnuravi