Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display toast if insufficient permissions to access page #50

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

arkadiuszbachorski
Copy link
Collaborator

Display toast if insufficient permissions to access page

♻️ Current situation & Problem

User is redirected without any feedback. Just for UX clarify, we need users to know why redirection happened.

Closes #21

⚙️ Release Notes

  • Display toast if insufficient permissions to access page

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.05%. Comparing base (190d2ad) to head (9be7d4f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
modules/firebase/app.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   27.07%   27.05%   -0.01%     
==========================================
  Files         182      182              
  Lines        6341     6344       +3     
  Branches      300      300              
==========================================
  Hits         1716     1716              
- Misses       4530     4533       +3     
  Partials       95       95              
Files with missing lines Coverage Δ
modules/firebase/app.ts 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190d2ad...9be7d4f. Read the comment docs.

@arkadiuszbachorski arkadiuszbachorski merged commit 6a16d8d into main Sep 17, 2024
8 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/display-toast-on-errors branch September 17, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle 403 errors
2 participants