-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use engagehf-models package #41
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 27.26% 27.21% -0.04%
==========================================
Files 181 181
Lines 6296 6307 +11
Branches 299 299
==========================================
Hits 1716 1716
- Misses 4486 4497 +11
Partials 94 94
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @arkadiuszbachorski; great to see the usage of the shared package, very cool. Thank you to you and @pauljohanneskraft!
Use engagehf-models package
♻️ Current situation & Problem
Previously, model types were copied from Firebase repository. This PR aims to clean this up.
Closes #15
✅ Testing
It's a draft, because it relies on features from StanfordBDHG/ENGAGE-HF-Firebase#128 to work. We can merge this as StanfordBDHG/ENGAGE-HF-Firebase#128 gets released.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: