Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use engagehf-models package #41

Merged
merged 22 commits into from
Sep 15, 2024
Merged

Conversation

arkadiuszbachorski
Copy link
Collaborator

@arkadiuszbachorski arkadiuszbachorski commented Sep 10, 2024

Use engagehf-models package

♻️ Current situation & Problem

Previously, model types were copied from Firebase repository. This PR aims to clean this up.

Closes #15

✅ Testing

It's a draft, because it relies on features from StanfordBDHG/ENGAGE-HF-Firebase#128 to work. We can merge this as StanfordBDHG/ENGAGE-HF-Firebase#128 gets released.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 1.75439% with 168 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (3168b31) to head (b68d889).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
modules/firebase/medication.ts 2.09% 47 Missing ⚠️
routes/~_dashboard/~patients/actions.tsx 0.00% 23 Missing ⚠️
routeTree.gen.ts 0.00% 19 Missing ⚠️
modules/firebase/models.ts 7.70% 12 Missing ⚠️
routes/~_dashboard/~patients/utils.ts 0.00% 11 Missing ⚠️
modules/firebase/user.ts 0.00% 7 Missing ⚠️
modules/user/queries.tsx 0.00% 4 Missing ⚠️
routes/~_dashboard/~patients/clientUtils.ts 0.00% 4 Missing ⚠️
routes/~_dashboard/patients/$id/~index.tsx 0.00% 3 Missing ⚠️
routes/~_dashboard/~patients/~index.tsx 0.00% 3 Missing ⚠️
... and 24 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   27.26%   27.21%   -0.04%     
==========================================
  Files         181      181              
  Lines        6296     6307      +11     
  Branches      299      299              
==========================================
  Hits         1716     1716              
- Misses       4486     4497      +11     
  Partials       94       94              
Files with missing lines Coverage Δ
modules/firebase/allergy.ts 0.00% <ø> (ø)
modules/firebase/app.ts 0.00% <ø> (ø)
modules/firebase/localizedText.ts 0.00% <ø> (ø)
modules/firebase/role.ts 0.00% <ø> (ø)
modules/user/table.tsx 0.00% <ø> (ø)
...ackages/design-system/src/forms/useForm/useForm.ts 100.00% <100.00%> (ø)
routes/~_dashboard/~patients/PatientForm.tsx 0.00% <ø> (ø)
modules/firebase/AuthProvider.ts 0.00% <0.00%> (ø)
modules/firebase/UserProvider.tsx 0.00% <0.00%> (ø)
modules/firebase/utils.ts 0.00% <0.00%> (ø)
... and 31 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad11c0a...b68d889. Read the comment docs.

@arkadiuszbachorski arkadiuszbachorski marked this pull request as ready for review September 10, 2024 18:49
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Sep 11, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arkadiuszbachorski; great to see the usage of the shared package, very cool. Thank you to you and @pauljohanneskraft!

@arkadiuszbachorski arkadiuszbachorski merged commit 3c4f08a into main Sep 15, 2024
9 of 10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/use-engagehf-models branch September 15, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Import helpers and types from Firebase repository
2 participants